GNOME Bugzilla – Bug 312080
[0.9] [API] GST_BUFFER_FOO_IS_VALID(buf) is bad API
Last modified: 2005-09-02 15:17:13 UTC
Currently we have a couple of macros like this: GST_BUFFER_OFFSET_IS_VALID (buffer) That is bad API IMHO and should rather be: GST_BUFFER_OFFSET_IS_VALID (offset) and GST_BUFFER_HAS_VALID_OFFSET (buffer) (I'd be willing to fix gstreamer, gst-plugins-base and gst-plugins of course if people agree that the suggested API is better). Cheers -Tim
Note also that it is GST_CLOCK_TIME_IS_VALID (clocktime) so that's also a bit inconsistent with the current API Cheers -Tim
any word from the maintainers on this?
I guess it's best to just leave it as is, unless we also want to change all the accessor macros like GST_BUFFER_OFFSET etc., which seems a little bit over the top . => closing. Cheers -Tim