GNOME Bugzilla – Bug 311445
Making esound optional
Last modified: 2008-04-30 05:13:17 UTC
Lately, I've been patching a number of GNOME applications depending on esound, to make those dependencies optional at compilation time. Nautilus is one of them. I'll attach a simple patch I created against CVS HEAD in case you want to review it. It adds a --enable-esd switch to the configure script (the default behaviour is to compile with esound support). As for the motivation for this, there are a number of reasons why a user might want to compile applications without esound; however, I also understand that in the particular case of Nautilus, turning esound into an optional dependency might have undesired effects. Please let me know if maybe this request is not very reasonable, and a different approach is needed :). Thanks.
Created attachment 49697 [details] [review] nautilus-HEAD-optional_esd.patch
Thanks for your bug report and your efforts! Maybe you could also submit this patch to the Nautilus mailing list [1] for review? [1] http://mail.gnome.org/mailman/listinfo/nautilus-list
Is this in any way related to bug #310972?
Kjartan, Yes, somewhat related. There's a gentoo bug[1] where people have requested to make esound optional whenever possible, at least as far as base GNOME packages go. So far, libgnome, libgnomeui and gnome-session are being patched in our tree since those packages already implement the necessary #ifdef magic, they only needed slight revised configure scripts. I've submitted those patches upstream as bug #310972, #310974 and #310979 respectively. There are 3 additional base GNOME packages that currently depend on esound: nautilus, control-center and gnome-media. I have patches for them too, but they are special in the sense that apparently those packages were designed to rely on esound from the start so they include #ifdef's that might require special care. That's why we're not patching them on gentoo yet, and I ask for upstream's opinion first, starting with nautilus (hence, this bug :)). [1] http://bugs.gentoo.org/show_bug.cgi?id=6920
Why are the three packages (nautilus, control-center and gnome-media) just updated to use gstreamer? I know this would take more time, but if it's a choice between esound or no sound I think I'd have to pick the third option :) For the record, I'm using Gentoo and I HATE esound. It makes everything sound terrible on my system. I'd still like nautilus to make sound though. Just not the the Evil Sound Daemon.
The last comment was written in September 2005... when will be finally removed ESound from GNOME?
Created attachment 97535 [details] [review] this patch is the latest from Gentoo portage.
I think it would be good to drop ESound dependency altogether. Gentoo already does this in its packages, and I can't see any regression.
Created attachment 110022 [details] [review] more old silliness. Silly enough, we actually do not depend on ESD at all anymore. The nautilus-audio-player code seemed to have died before the GIO merge, but the config junk just hasn't left us yet. So, here's the simple patch to rid ourselves of what's left of ESD.
Good catch. Please commit the patch to trunk and to the GNOME 2.22 branch.
2008-04-30 A. Walton <awalton@gnome.org> * configure.in: * src/file-manager/fm-icon-view.c: Remove false dependency for ESound. Closes bug #311445. Committed.