After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 311079 - Make use of SetWindowTextW in gdk_window_set_title [patch]
Make use of SetWindowTextW in gdk_window_set_title [patch]
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Backend: Win32
2.6.x
Other Windows
: Normal normal
: ---
Assigned To: gtk-win32 maintainers
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2005-07-21 03:56 UTC by Peter Zelezny
Modified: 2005-07-21 07:30 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch to use SetWindowTextA/W. (1.03 KB, patch)
2005-07-21 03:57 UTC, Peter Zelezny
none Details | Review

Description Peter Zelezny 2005-07-21 03:56:15 UTC
With this patch it's possible to set titlebars with characters outside the
current CodePage.

Open issues:

Is SetWindowTextW in Win98, or should we GetProcAddress? MSDN is typically
unclear on this.

Setting some text with a č (C with caron) shows up as normal c. I guess Windows
strips the caron for some reason (?). It's still an improvement, as the current
code sets a blank titlebar because g_locale returns NULL.
Comment 1 Peter Zelezny 2005-07-21 03:57:19 UTC
Created attachment 49497 [details] [review]
Patch to use SetWindowTextA/W.
Comment 2 Tor Lillqvist 2005-07-21 07:30:22 UTC
Thanks, applied to HEAD and gtk-2-6:

2005-07-21  Tor Lillqvist  <tml@novell.com>

	* gdk/win32/gdkwindow-win32.c (gdk_window_set_title): Use
	wide-char API when available. (#311079, Peter Zelezny)