GNOME Bugzilla – Bug 310906
should try to use GTK theme icon for default face
Last modified: 2005-08-15 22:22:52 UTC
We should try to use a GTK themed icon for default face before falling back to nobody.png. Patch to follow.
Created attachment 49416 [details] [review] patch Ok to commit?
Looks good. On the GDM mailing list, somebody reported an issue with the way the face browser works. They don't like the feature that it looks first in $HOME/.face, which can be slow on a large network with NFS mounted home directories (where accessing $HOME directories causes a mount, which can be slow). Therefore, it was suggested that a new feature be added, a gdm.conf option which specifies "use this face image for everybody, don't go look for $HOME/.face at all". It would also be nice to have such a feature. Since you are mucking with this part of the code, would you mind adding such a feature? You can commit your patch either way. Leave this bug open if you don't fix the "use this face image for everbody" feature.
Could you also add a section to the Configuration in gdm.xml to explain how to set up the face browser using GTK themed icons? Lastly, I notice that the code in gdmlogin and gdmgreeter are pretty much the same. Wouldn't it be better to move this function into gdmcommon.c?
Ok, I have committed most of this. It took a little refactoring to do it. For now, I just disabled accessing remote home directories altogether. I think this is sensible since I don't think it will ever work correctly. I still have to update the docs.
Okay, please close the bugs after updating the docs. Note, I further refactored the code a bit more to move some functions from libgdmcommon to libgdmwm because it caused a Solaris linking problem. This is better since libgdmcommon stuff is used by all GUI programs (gdmlogin, gdmchooser, gdmsetup, and gdmgreeter) while the gdmwm stuff is used by everything except gdmsetup. The functions you added to gdmcommon used gdmwm stuff, so better belongs with libgdmwm.a
*** Bug 310908 has been marked as a duplicate of this bug. ***
I went ahead and updated the docs for this, so closing. The Face Browser docs really needed some help, so I made them more clear. Previously the docs implied that the Face Browser can only be used in the GTK+ Greeter, but you can also use it with the Themed Greeter if the theme supports it. Now this should be more clear.