GNOME Bugzilla – Bug 310653
huge icons in the fileselect when using gtk native backend
Last modified: 2006-08-11 11:27:39 UTC
if i remove the Gnome-VFS based filesystem plugin from /gtk-2.0/2.4.0/filesystem and open the file chooser in an application i what the screenshot shows, Some of the icons are huge.
Created attachment 49320 [details] screenshot showing the problem
How weird! That same icon gets scaled for me. Could you set a breakpoint in gtk_file_system_unix_volume_render_icon(), trace through the child functions, and see why the icon is not getting scaled?
I did this but i don't know what i'm looking for, all the pixel_size arguments that are passed are equal to 16.
I can reproduce this now. No idea on what is going on, but I'll take a look.
You might want to look at bug 311318.
*** Bug 312062 has been marked as a duplicate of this bug. ***
maybe a bug to fix for 2.8? that's not a big issue but quite ugly ...
Sebastien, can you attach /usr/share/icons/gnome/index.theme ?
If you had [48x48/mimetypes] Size=48 Context=MimeTypes Type=Fixed instead of [48x48/mimetypes] Size=48 Context=MimeTypes Type=Scalable that would explain it...
Created attachment 50834 [details] index.theme with GNOME 2.11.91 Right, all the non-scalable categories use "Fixed", changing to "Scalable" fix the issue
Ok, it is an gnome-icon-theme issue then, and it has recently been fixed.
That happens again with gnome-icon-theme 2.13.4 due to that change: 2005-12-22 Rodney Dawes <dobey@novell.com> * index.theme.in: Fix filesystems and mimetypes at 48x48 size to be Fixed instead of Scalable (probable fix for bug #315841) Reopening
The correct solution is to provide all the required resolutions (16x16, 24x24 and scalable). Yet currently git requires to theme every single mimetype out there. I propose to create the following types to draw at 16x16 and 24x24 and some hacker will have to create Makefile magic to symlink these to the mime type insanity. * text-plain * text-rich * text-script * image * video * sound * executable * font * package * office-calendar * office-presentation * office-spreadsheet How does that plan sound to you guys?
Nah. We will use the stuff in the naming spec. I'll make git use it this weekend, and it will then depend on icon-naming-utils to install, as well as tango does. This shouuld help resolve a lot of the issues with this stuff.
Also, if someone could actually provide a list of all the busted icons, that would help tremendously.
*** Bug 328139 has been marked as a duplicate of this bug. ***
*** Bug 328022 has been marked as a duplicate of this bug. ***
*** Bug 330035 has been marked as a duplicate of this bug. ***
So, we still have this bug. Raising the priority so that it gets solved for 2.14. It's really important since it makes our UI really ugly.
fast-user-switch-applet is having similar issues, it's using the "user-info" icon in a menu, but it isn't able to scale it to 16x16 and appears in the context menu at 48x48.
(In reply to comment #20) > fast-user-switch-applet is having similar issues, it's using the "user-info" > icon in a menu, but it isn't able to scale it to 16x16 and appears in the > context menu at 48x48. Ross, to which icon theme does your "user-info" icon resolve? What's the entry in its index.theme? I think we really have to scale icons down in GTK+ if the icon theme only provides larger, fixed-size versions.
$ locate user-info /usr/share/icons/gnome/48x48/apps/user-info.png $ cat /usr/share/icons/gnome/index.theme ... [48x48/apps] Size=48 Context=Applications Type=Fixed
(forgot to say, this is gnome-icon-theme 2.14.0)
Federico, let's not "fix" this by making gtk+ basically ignore the "Fixed" property of theme directories. I'll fix the 2.14 branch to make the 48x48 images be scalable I guess, for 2.14. For 2.16, we will have a lot more SVG icons that are actually scalable, and should be able to fix this in a much better way.
There's still some issues in 2.14.1.
"Still some issues?" Please elaborate with useful data. I've reverted the Fixed/Scalable change that I committed previously, in an attempt to fix another bug. If there are still issues, do they also show up with the latest version of the 2.12.x release? If so, what are they? Just saying "there are still issues" doesn't tell me what the issues are. There are 1300 icons in the theme. The majority of them are not available in all sizes. And yes, setting bitmaps to scalable is a horrible workaround.
I do notice that certain programs (like gnome-system-monitor) like grabbing the largest icon they can find rather than sticking to a standardised size. This should probably be filed with that rather than the icon theme. (Why do we provide those nasty X-Chat icons anyway? X-Chat has a very nice icon which they put in /usr/share/pixmaps...)
(In reply to comment #26) > "Still some issues?" Please elaborate with useful data. I've reverted the > Fixed/Scalable change that I committed previously, in an attempt to fix another > bug. Please, please, please: see bug 332894
(In reply to comment #26) > "Still some issues?" Please elaborate with useful data. I've reverted the > Fixed/Scalable change that I committed previously, in an attempt to fix another > bug. If there are still issues, do they also show up with the latest version of > the 2.12.x release? If so, what are they? Just saying "there are still issues" > doesn't tell me what the issues are. There are 1300 icons in the theme. The > majority of them are not available in all sizes. And yes, setting bitmaps to > scalable is a horrible workaround. I can at least see a huge icon in the right-click menu of the fast-user-switch applet. I can't test with a 2.12.x version right now, but I believe it didn't happen.
There is also a too large icon for Epiphany in the preferred applications capplet.
(In reply to comment #30) > There is also a too large icon for Epiphany in the preferred applications > capplet. > Fixed by patch in bug 332894
(In reply to comment #29) > > I can at least see a huge icon in the right-click menu of the fast-user-switch > applet. Fixed by patch in bug 332894. cough*applyit*cough
Are these /still/ issues with CVS gnome-icon-theme?
I don't see any bad-sized icon from a long time... At least in file selector and user switch applet. I think you can close this bug.
no recent issue on my box neither, nor Ubuntu bug about it, I think that bug can be closed too
Closing as per last two comments.