GNOME Bugzilla – Bug 310017
iPod source doesn't compile with newer hal (>= 0.5)
Last modified: 2005-08-28 13:47:23 UTC
The current ipod code in cvs won't compile with versions of hal >= 0.5. I'm attching the patch from the merge arch branch which will make it use hal >= 0.5 - however this makes it require the higher version. It's probably better to check and compile against either version.
Created attachment 48948 [details] [review] patch from merge branch
Created attachment 51030 [details] [review] update This patch works with hal 0.5.3-4 and dbus 0.35.2-1 (rawhide). It initializes/frees the dbuserror and uses init_direct() so that a context is assigned. Without those two, it crashes on initialization.
Created attachment 51031 [details] [review] oops Bla - only works if a connection already exists, and it does not... This patch fixes my previous one.
Created attachment 51032 [details] [review] whee Bla - this prefixes paths with file:// so I can play songs from my ipod (playbin demands valid VFS URIs). Without it, my terminal is stuffed with "/media/ipod/... is not a valid URI" warnings from GStreamer's playbin element. Other sources work fine.
Current CVS does not compile with --with-dbus, with DBUS >= 0.30, because the code in rb-dbus-remote needs updating to the newer API. Also you patch drop support for HAL < 0.5 which would be good to keep, because some Gnome 2.10 desktops (which is the lowest environment we're currently targetting) don't have the newer version of HAL. I guess we could make parts of the code coditional on the HAL version. Apart from version issues, your patch looks good to me.
I'm working on updating the core D-BUS remoting support, so that shouldn't be a concern.
I merged this change, but attempted to preserve the old HAL support too.