After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 309879 - [i18n] Schema string cleanups
[i18n] Schema string cleanups
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: Preferences
3.17.x
Other All
: Normal minor
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2005-07-09 12:37 UTC by Clytie Siddall
Modified: 2017-11-02 15:58 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Proposed schema patch (against HEAD). (2.04 KB, patch)
2005-07-09 14:46 UTC, Christian Neumair
none Details | Review
Proposed source patch (against HEAD). (5.18 KB, patch)
2005-07-09 15:05 UTC, Christian Neumair
committed Details | Review
gschema: clarify/simplify some strings in the gconf schemas (2.33 KB, patch)
2017-08-17 20:20 UTC, António Fernandes
committed Details | Review

Description Clytie Siddall 2005-07-09 12:37:41 UTC
1. duplicate strings, bar a capital letter or a full stop/period

(a)
.po:128
reference:	⑤	../libnautilus-private/apps_nautilus_preferences.schemas.in.h:13
Original:	⌘0	Default column order in the list view

.po:129
reference:	⑤	../libnautilus-private/apps_nautilus_preferences.schemas.in.h:14
Original:	⌘0	Default column order in the list view.


(b)
.po:132
reference:	⑤	../libnautilus-private/apps_nautilus_preferences.schemas.in.h:17
Original:	⌘0	Default list of columns visible in the list view

.po:133
reference:	⑤	../libnautilus-private/apps_nautilus_preferences.schemas.in.h:18
Original:	⌘0	Default list of columns visible in the list view.


(c) [The second string has a full stop before the last word.]
po:519
reference:	⑤	../libnautilus-private/nautilus-program-choosing.c:137
flag:	⑤	c-format
Original:	⌘0	
\"%s\" can't open \"%s\" because \"%s\" can't access files at \"%s\" 
locations.

.po:523
reference:	⑤	../libnautilus-private/nautilus-program-choosing.c:169
flag:	⑤	c-format
Original:	⌘0	
\"%s\" can't open \"%s\" because \"%s\" can't access files at \"%s\".
locations.


(d)  [The second string has a full stop before the last word.]
.po:521
reference:	⑤	../libnautilus-private/nautilus-program-choosing.c:143
flag:	⑤	c-format
Original:	⌘0	
The default action can't open \"%s\" because it can't access files at \"%s\" 
locations.

.po:525
reference:	⑤	../libnautilus-private/nautilus-program-choosing.c:176
flag:	⑤	c-format
Original:	⌘0	
The default action can't open \"%s\" because it can't access files at \"%s\".
locations.

(e)
.po:907
reference:	⑤	../src/nautilus-emblem-sidebar.c:242
Original:	⌘0	
This is probably because the emblem is a permanent one, and not one you 
added yourself.

po:910
reference:	⑤	../src/nautilus-emblem-sidebar.c:277
Original:	⌘0	
This is probably because the emblem is a permanent one, and not one that you 
added yourself.

(correct syntax is "and not one you yourself have added")

(f) a whole group of them: do we need both sets?

.po:130
reference:	⑤	../data/totem.glade.h:111
Original:	⌘0	Zoom In

.po:131
reference:	⑤	../data/totem.glade.h:112
Original:	⌘0	Zoom Out

.po:132
reference:	⑤	../data/totem.glade.h:113
Original:	⌘0	Zoom Reset

.po:133
reference:	⑤	../data/totem.glade.h:114
Original:	⌘0	Zoom in

.po:134
reference:	⑤	../data/totem.glade.h:115
Original:	⌘0	Zoom out

.po:135
reference:	⑤	../data/totem.glade.h:116
Original:	⌘0	Zoom reset

(g)
po:162
reference:	⑤	../data/totem.schemas.in.h:1
Original:	⌘0	Enable deinterlacing

.po:163
reference:	⑤	../data/totem.schemas.in.h:2
Original:	⌘0	Enable deinterlacing.

(h) another series:
po:165
reference:	⑤	../data/totem.schemas.in.h:4
Original:	⌘0	Name of the visual effects plugins

.po:166
reference:	⑤	../data/totem.schemas.in.h:5
Original:	⌘0	Name of the visual effects plugins.


.po:167
reference:	⑤	../data/totem.schemas.in.h:6
Original:	⌘0	Path to the optical media device

.po:168
reference:	⑤	../data/totem.schemas.in.h:7
Original:	⌘0	Path to the optical media device.

.po:169
reference:	⑤	../data/totem.schemas.in.h:8
Original:	⌘0	Repeat mode

.po:170
reference:	⑤	../data/totem.schemas.in.h:9
Original:	⌘0	Repeat mode.

.po:171
reference:	⑤	../data/totem.schemas.in.h:10
Original:	⌘0	Resize the canvas automatically on file load

.po:172
reference:	⑤	../data/totem.schemas.in.h:11
Original:	⌘0	Resize the canvas automatically on file load.

(i)
po:175
reference:	⑤	../data/totem.schemas.in.h:14
Original:	⌘0	Shuffle mode

.po:176
reference:	⑤	../data/totem.schemas.in.h:15
Original:	⌘0	Shuffle mode.

(j) another series
.po:179
reference:	⑤	../data/totem.schemas.in.h:18
Original:	⌘0	The brightness of the video

.po:180
reference:	⑤	../data/totem.schemas.in.h:19
Original:	⌘0	The brightness of the video.

.po:181
reference:	⑤	../data/totem.schemas.in.h:20
Original:	⌘0	The contrast of the video

.po:182
reference:	⑤	../data/totem.schemas.in.h:21
Original:	⌘0	The contrast of the video.

.po:183
reference:	⑤	../data/totem.schemas.in.h:22
Original:	⌘0	The hue of the video

.po:184
reference:	⑤	../data/totem.schemas.in.h:23
Original:	⌘0	The hue of the video.

.po:185
reference:	⑤	../data/totem.schemas.in.h:24
Original:	⌘0	The saturation of the video

.po:186
reference:	⑤	../data/totem.schemas.in.h:25
Original:	⌘0	The saturation of the video.

(k)
po:191
reference:	⑤	../data/totem.schemas.in.h:30
Original:	⌘0	Whether to enable debug for the playback engine

.po:192
reference:	⑤	../data/totem.schemas.in.h:31
Original:	⌘0	Whether to enable debug for the playback engine.

(l)
.po:194
reference:	⑤	../data/totem.schemas.in.h:33
Original:	⌘0	X coordinate for the Playlist

.po:195
reference:	⑤	../data/totem.schemas.in.h:34
Original:	⌘0	X coordinate for the Playlist.

.po:196
reference:	⑤	../data/totem.schemas.in.h:35
Original:	⌘0	Y coordinate for the Playlist

.po:197
reference:	⑤	../data/totem.schemas.in.h:36
Original:	⌘0	Y coordinate for the Playlist.


2.
This type of string (there was a series of them) does not work in my language, and most likely in many 
others.

po:333
auto:	⑤	localizers: tag used to detect the x1st copy of a file
reference:	⑤	../libnautilus-private/nautilus-file-operations.c:1260
Original:	⌘0	st copy)

However, if you supply the variable, as in the following string, we can translate the string by changing 
the position of the words, and using our own way of indicating order.

po:329
auto:	⑤	appended to new link file
reference:	⑤	../libnautilus-private/nautilus-file-operations.c:1227
flag:	⑤	c-format
Original:	⌘0	%dth link to %s

Please supply the variable wherever possible. I cannot translate the first type of string in any useful 
way. :(


3.
Please use the gettext plurals facility. This will avoid me having to enter the same string twice (we have 
no plurals in that sense), and many languages have more than one plural case, which you're not 
accommodating here. By using the gettext plurals facility, you allow each translator to get your 
meaning across. I include some examples below, but there will be many more in the Nautilus file.

.po:511
reference:	⑤	../libnautilus-private/nautilus-icon-dnd.c:754
Original:	⌘0	
Do you want to switch to manual layout and leave this item where you dropped 
it? This will clobber the stored manual layout.

.po:513
reference:	⑤	../libnautilus-private/nautilus-icon-dnd.c:758
Original:	⌘0	
Do you want to switch to manual layout and leave these items where you 
dropped them? This will clobber the stored manual layout.

po:514
Translator:	③	libnautilus-p
reference:	⑤	../libnautilus-private/nautilus-icon-dnd.c:764
Original:	⌘0	
Do you want to switch to manual layout and leave this item where you dropped 
it?

.po:515
reference:	⑤	../libnautilus-private/nautilus-icon-dnd.c:767
Original:	⌘0	
Do you want to switch to manual layout and leave these items where you 
dropped them?

po:692
reference:	⑤	../src/file-manager/fm-directory-view.c:6328
Original:	⌘0	_Browse Folder

.po:693
reference:	⑤	../src/file-manager/fm-directory-view.c:6330
Original:	⌘0	_Browse Folders

.po:668
auto:	⑤	name, stock id
reference:	⑤	../src/file-manager/fm-directory-view.c:5891
reference:	⑤	../src/file-manager/fm-directory-view.c:6387
Original:	⌘0	Ma_ke Link

.po:696
reference:	⑤	../src/file-manager/fm-directory-view.c:6386
Original:	⌘0	Ma_ke Links

po:807
reference:	⑤	../src/file-manager/fm-properties-window.c:2272
Original:	⌘0	_Names:

.po:808
reference:	⑤	../src/file-manager/fm-properties-window.c:2274
Original:	⌘0	_Name:


4.
Are these comments for translators? The gettext developer comment facility is supposed to give us 
instructions and explanations about strings. If so, the original string does not conform to the comment. 
If not, it's just confusing to have it there.

po:805
auto:	⑤	Also set the title field here, with a trailing carriage return &
auto:	⑤	* space if the value field has two lines. This is a hack to get the
auto:	⑤	* "Contents:" title to line up with the first line of the
auto:	⑤	* 2-line value. Maybe there's a better way to do this, but I
auto:	⑤	* couldn't think of one.
auto:	⑤	
reference:	⑤	../src/file-manager/fm-properties-window.c:1858
Original:	⌘0	Contents:

from Clytie, Vietnamese free-software translation team
Comment 1 Christian Neumair 2005-07-09 14:34:14 UTC
Thanks for your observations! This kind of report is very helpful.
Comment 2 Christian Neumair 2005-07-09 14:46:20 UTC
Created attachment 48864 [details] [review]
Proposed schema patch (against HEAD).

This one tries to clarify/simplify some strings in the gconf schemas.
Comment 3 Christian Neumair 2005-07-09 15:05:42 UTC
Created attachment 48865 [details] [review]
Proposed source patch (against HEAD).
Comment 4 Christian Neumair 2005-07-09 15:13:39 UTC
1.

(a,b) fixed by patch #1
(c,d,e) fixed by patch #2
(f,g,h) have nothing to do with Nautilus. I'll open a new bug against Totem.

2.

I'm afraid, we probably can't do much about them. These strings are very
oriented towards western languages. I'll investigate whether we can drop them or
solve this otherwise.

3.
libnautilus-private/nautilus-icon-dnd.c: fixed by patch #2.
These are #ifdef'ed out, i.e. they won't even be included in the resulting
application, although gettext doesn't know that.

src/file-manager/fm-directory-view.c:
src/file-manager/fm-properties-window.c: fixed by patch #3.

4.
These comments are very helpful for programmers, but not for translators. If
(x)gettext supports a special flag for comments that shouldn't be included in
the po files, it would be trivial to fix.

Again, thanks for your efforts!
Comment 5 Christian Neumair 2005-07-09 15:20:29 UTC
I've also submitted the patches to the Nautilus mailing list [1] for review,
which will take place next monday at the earliest. Bug 309896 contains the Totem
suggestions.

[1] http://mail.gnome.org/archives/nautilus-list/2005-July/msg00092.html
Comment 6 Christian Neumair 2005-07-11 11:29:27 UTC
From [1]:

"I commited the second patch, although i changed how the commented out
part was made not translated. Its way to risky to leave the whole file
untranslated, as strings can easily be added to it later.

However, i'm not sure about the first patch. Its not uncommon for the
long and short string in gconf schemas to be similar. And I've never
seen schemas with only short strings, so I'm not sure how well our tools
etc handle that."

[1] http://mail.gnome.org/archives/nautilus-list/2005-July/msg00110.html
Comment 7 Christian Neumair 2006-02-25 22:02:41 UTC
Updating version and description schema patch missed string freze. Milestoning to 2.16.
Comment 8 Cosimo Cecchi 2008-03-08 18:57:54 UTC
This is still valid, setting target 2.24.
Comment 9 Cosimo Cecchi 2011-03-31 19:36:49 UTC
The GSettings schema still uses the wrong strings :(
Targeting 3.2.
Comment 10 William Jon McCann 2012-08-13 22:54:34 UTC
Any chance someone can update the patch for this one?
Comment 11 Carlos Soriano 2015-09-01 14:02:36 UTC
I can't understand at all these or which ones are fixed or not, please report in a separate bug report those who still need fixing... if someone wants to come with a summary of them, I will glad to fix them.
Comment 12 Cosimo Cecchi 2016-09-06 15:17:10 UTC
What is left to be done here is to forward-port the patch that was not committed to change the strings in https://git.gnome.org/browse/nautilus/tree/data/org.gnome.nautilus.gschema.xml.
The problem mentioned at 1a/1b in the original post (strings that differ only for a terminal period) is still there, and Christian's patch also tweaked two other very similar strings to be the same instead.
Comment 13 António Fernandes 2017-08-17 20:20:59 UTC
Created attachment 357837 [details] [review]
gschema: clarify/simplify some strings in the gconf schemas

As per comment 12, forward-porting schemas patch.
Comment 14 Carlos Soriano 2017-08-18 08:02:46 UTC
Review of attachment 357837 [details] [review]:

Looks good, thanks Antonio!
Comment 15 António Fernandes 2017-11-02 15:58:50 UTC
Attachment 357837 [details] pushed as 046e9e8 - gschema: clarify/simplify some strings in the gconf schemas