After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 309118 - statusbar rework
statusbar rework
Status: RESOLVED FIXED
Product: eog
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: EOG Maintainers
EOG Maintainers
Depends on:
Blocks:
 
 
Reported: 2005-06-27 10:56 UTC by Paolo Borelli
Modified: 2005-07-02 00:23 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch (8.37 KB, patch)
2005-06-27 10:56 UTC, Paolo Borelli
none Details | Review
eog-statusbar.c (to add in the shell directory) (4.25 KB, text/plain)
2005-06-27 10:57 UTC, Paolo Borelli
  Details
eog-statusbar.h (2.18 KB, text/plain)
2005-06-27 10:58 UTC, Paolo Borelli
  Details

Description Paolo Borelli 2005-06-27 10:56:02 UTC
EOG currently uses GnomeAppBar for the statusbar, which is depracated.

It also has other problems:
- menu items tooltips are not shown in the statusbar as they should
- doesn't have a resize grip
- the progress bar is always visible even which there is nothing in progress

The attached patch adresses the problems above, by creating a very simple
EogStatusbar which inherits from GtkStatusbar.

Some notes:
- the resize grip is hidden when the window is maximized (this is what
eog_window_window_state_event is for)
- I moved the progress bar on the right, where in my opinion looks better (see
epiphany, firefox, etc)
- the progress bar is hidden by default and shown only during progess (this is
why I had to shuffle some of the gtk_widget_show/show_all in the window constructor)

At a later stage, if needed, it is easy to add furter messages like ("loading
file..." etc): just add a new message context and use gtk_statusbar_push()
Comment 1 Paolo Borelli 2005-06-27 10:56:46 UTC
Created attachment 48406 [details] [review]
patch
Comment 2 Paolo Borelli 2005-06-27 10:57:43 UTC
Created attachment 48407 [details]
eog-statusbar.c (to add in the shell directory)
Comment 3 Paolo Borelli 2005-06-27 10:58:14 UTC
Created attachment 48408 [details]
eog-statusbar.h
Comment 4 Paolo Borelli 2005-06-27 11:00:42 UTC
oops in eog-statusbar.h is still declared eog_statusbar_set_image_info() which
is a leftover. Just delete it.
Comment 5 Tim Gerla 2005-07-02 00:23:41 UTC
Patches applied to CVS. Thanks!