GNOME Bugzilla – Bug 309046
delete confirmation dialog should be removed
Last modified: 2005-11-09 03:38:34 UTC
Distribution/Version: Ubuntu Hoary 1. Open a bunch of images in the collection view. 2. Delete one of the images. 3. Look at the confirmaton dialog. There is no title, it uses the warning icon instead of the question icon, the buttons are in different order than in nautilus delete confirmation dialog, it doesn't display the name of the file and the entire text is on one line. Please see the attached screenshot. I included the nautilus confirmation dialog for comparison.
Created attachment 48341 [details] screenshot of confirmation dialog
Agreed. I think if it works like nautilus it'd be cool. Making a patch on the latest CVS head.
I think Nautilus uses something from the eel library for this; maybe you could talk with the nautilus maintainers about using eel for this? They tend to frown on other people linking against eel, but if it is there, standardizing seems like it would be useful.
Well, heres the patch and a file list. I think it'd help if user sees a list of files s/he is going to delete, not just 'move 2 files to trash', say 'move $1, $2 to trash ?' That'd be good, probl'y a separate bug?.
Created attachment 48357 [details] [review] Implements Nautilus like dialog. Against latest CVS.
Created attachment 48358 [details] fixed image. A screen shot: How it looked on my systems
Looks good, thanks. About the file list: Nautilus doesn't show a list of files either. What happens when the user tries to delete great many files at once? I think it would be better for consistency to just mimic what Nautilus does.
A couple of comments: - the dialog should not have a title according to the HIG (it was one of the few things the old dialog got right) - if someone wants to implement a dialog with a list, gedit-close-confirmation-dialog.c contains code that can be used a more generic question is: do we really need this dialog? (nautilus doesn't ask for confirmation when moving to the trash)
I'm OK with removing the dialog entirely.
I'm tending to agree with Paolo and Teppo; matching nautilus would be nice. I think we can remove the dialog entirely.
Changing the summary and upping versions.
I agree about matching nautilus and removing the delete confirmation dialog.
Applied in HEAD. Delete (move to trash) confirmation dialog removed. Thanks!