After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 308738 - Preference can't handle devices with the same names.
Preference can't handle devices with the same names.
Status: RESOLVED FIXED
Product: gnome-applets
Classification: Other
Component: mixer
2.10.x
Other All
: Normal normal
: ---
Assigned To: gnome-applets Maintainers
gnome-applets Maintainers
Depends on:
Blocks:
 
 
Reported: 2005-06-23 05:33 UTC by Paisa Seeluangsawat
Modified: 2005-12-17 16:59 UTC
See Also:
GNOME target: ---
GNOME version: 2.9/2.10

Attachments
fix (1.57 KB, patch)
2005-10-15 16:51 UTC, Ronald Bultje 		none Details | Review
Update (1.75 KB, patch)
2005-10-16 19:55 UTC, Ronald Bultje 		none Details | Review

Description Paisa Seeluangsawat 2005-06-23 05:33:39 UTC 
Please describe the problem:
In Volume Control Preference window.  I have two devices
with the same name, "wave" (for capture and playback).  No
matter which one I choose, the widget will control the
capture "wave" device.

Steps to reproduce:


Actual results:


Expected results:


Does this happen every time?
yes

Other information:
Comment 1 Ronald Bultje 2005-06-28 10:27:49 UTC 
Confirmed; we indeed don't.
Comment 2 Ronald Bultje 2005-10-15 16:51:29 UTC 
Created attachment 53523 [details] [review]
fix

This patch should fix your bug. The same patch should be applied to other parts
that copied the same code segment, such as gnome-volume-control. Please let me
know if this fixes your problem.
Comment 3 Paisa Seeluangsawat 2005-10-16 05:05:52 UTC 
Thank you for the patch.  I haven't compiled Gnome from source in
a while, and won't have time to do it again soon.

However, I have a question about the patch.  Say if I have three
devices with the name "wave".  Won't the code produce "wave",
"wave #2", and "wave #2"?  The elements in the list "collection"
have unique names, so the counter "samenamenr" never get beyond 1.
Comment 4 Ronald Bultje 2005-10-16 19:55:02 UTC 
Created attachment 53555 [details] [review]
Update

Right, this fixes that.
Comment 5 Ronald Bultje 2005-12-17 16:59:22 UTC 
2005-12-17  Ronald S. Bultje  <rbultje@ronald.bitfreak.net>

        * load.c: (create_mixer_collection):
          Give unique names to mixers if multiple mixers have the same
          device name (#308738).