After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 307688 - GdkPangoRenderer lacks draw_trapezoid implementation
GdkPangoRenderer lacks draw_trapezoid implementation
Status: RESOLVED WONTFIX
Product: gtk+
Classification: Platform
Component: Backend: X11
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
: 311250 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2005-06-14 21:55 UTC by Torsten Schoenfeld
Modified: 2011-02-04 16:18 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Implementing draw_trapezoid (1.90 KB, patch)
2005-06-14 21:55 UTC, Torsten Schoenfeld
none Details | Review

Description Torsten Schoenfeld 2005-06-14 21:55:14 UTC
Calling pango_renderer_draw_trapezoid on a GdkPangoRenderer used to work, even
if it wasn't actually meant to be done. :-)

So here's a patch that implements draw_trapezoid.  This was my first journey
into Cairo land, so please double-check.
Comment 1 Torsten Schoenfeld 2005-06-14 21:55:37 UTC
Created attachment 47770 [details] [review]
Implementing draw_trapezoid
Comment 2 Matthias Clasen 2005-06-17 19:34:04 UTC
Doesn't this miss the conversion to/from pango units which is done in the other
drawing in that file ?
Comment 3 Matthias Clasen 2005-07-13 18:08:11 UTC
To answer my own question: no, it doesn't.
I wonder if we need to implement draw_glyph as well, then.
Comment 4 Owen Taylor 2005-07-13 19:04:38 UTC
Note that draw_glyph() wasn't implemented in GTK+-2.6, so it's different
from draw_trapezoid(), where there is a possible regression (depending on
how you view it.)
Comment 5 Owen Taylor 2005-07-22 13:42:21 UTC
*** Bug 311250 has been marked as a duplicate of this bug. ***
Comment 6 Matthias Clasen 2005-08-14 00:50:29 UTC
I guess this is effectively WONTFIXed by 2.8.0 going out without it now...
Comment 7 Marc Brockschmidt 2005-08-15 20:30:08 UTC
Erm, I don't think this bug is actually resolved (as the patch or an alternative
weren't applied). Could someone say if this bug will never be fixed or perhaps
in Gtk+ 2.8.1 or something like that?
Comment 8 Matthias Clasen 2005-08-15 20:36:18 UTC
Note that I didn't claim it was FIXED, I said it is effectively WONTFIXED, because 
we released a stable GTK+ without it. So, no it is not likely that it will be
fixed at a later point.
Comment 9 Owen Taylor 2005-08-16 02:00:07 UTC
Note that this problem affected no apps and didn't reflect realistic
usage - it was just a Gtk/Perl test case that was affected.