GNOME Bugzilla – Bug 307548
no error handling for non existent files (xfer)
Last modified: 2008-09-06 19:05:17 UTC
Please describe the problem: When using gnome_vfs_async_xfer I expected that when an uri is specified which targets a non existent file, that the sync_transfer callback would be called notifying that the current file does not exist and couldn't be tranferred. It should than continue with files still pending. At the moment this doesn't happen! When a file does not exists the whole process ends. Pending files aren't transfered and no error message whatsoever is notified. This makes the xfer function unusable for me. I could of course first query whether the files exist, but this should be handled in the xfer functions in my opinion. Steps to reproduce: 1. See the attached test app 2. 3. Actual results: The aync_xfer exits silently without complaining about the file which doesn't exist and further skipping all following files in the list Expected results: I would expect to get an ERROR status so I can handle the missing file. Further on following files should still be processed Does this happen every time? Yes Other information:
Created attachment 47726 [details] testcase Attached is a simple test application which simply outputs the different phases and states the xfer is put through. You'll see that it tries to transfer a file which doesn't exists and completes without complaining. Also, the second file (which might still be valid) is skipped after a non existent file is tried to transfer.
Ohh the gnome_vfs_xfer fun *sigh*. I am in the middle of rewriting small parts of it atm. Let's see if I can fix your problem while beeing there too. Thanks.
*** Bug 307931 has been marked as a duplicate of this bug. ***
*** Bug 315343 has been marked as a duplicate of this bug. ***
http://bugzilla.gnome.org/show_bug.cgi?id=340447 is another issue that is raised due to this.
Could you please see if the patch attached to bug #350649 fixes this for you?
Sorry, I meant bug #350647.
Federico: I doubt that informing the callback in PHASE_COMPLETED is enough. The reporter IMHO requested that we invoke the callbacks for all problems during the transfer (one call for each problem, with possibility to retry etc.).
gnome-vfs has been deprecated and superseded by gio/gvfs since GNOME 2.22, hence mass-closing many of the gnome-vfs requests/bug reports. This means that gnome-vfs is NOT actively maintained anymore, however patches are still welcome. If your reported issue is still valid for gio/gvfs, please feel free to file a bug report against glib/gio or gvfs. @Bugzilla mail recipients: query for gnome-vfs-mass-close to get rid of these notification emails all together. General further information: http://en.wikipedia.org/wiki/GVFS Reasons behind this decision are listed at http://www.mail-archive.com/gnome-vfs-list@gnome.org/msg00899.html