After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 307480 - problem with MAKE check in configure
problem with MAKE check in configure
Status: RESOLVED FIXED
Product: glibmm
Classification: Bindings
Component: build
2.6.x
Other All
: Normal normal
: ---
Assigned To: gtkmm-forge
gtkmm-forge
Depends on:
Blocks:
 
 
Reported: 2005-06-13 09:59 UTC by Marek Rouchal
Modified: 2005-10-29 10:12 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Marek Rouchal 2005-06-13 09:59:06 UTC
Version details: 2.6.1
Distribution/Version: Solaris 8 Sparc, RedHat Enterprise Linux 3.0 AMD64

glibmm's configure script does not work if MAKE != make,
but e.g. /some/special/gmake. Here is a patch for configure,
but I guess it has to be fixed in some configure.in, aclocal.m4
or the like...

diff -ruN glibmm-2.6.1-old/configure glibmm-2.6.1/configure
--- glibmm-2.6.1-old/configure	2005-06-13 10:05:22.441622000 +0200
+++ glibmm-2.6.1/configure	2005-06-13 10:07:28.882415000 +0200
@@ -19670,9 +19670,9 @@
 
 
 
-echo "$as_me:$LINENO: checking whether make is GNU Make" >&5
-echo $ECHO_N "checking whether make is GNU Make... $ECHO_C" >&6
-if $ac_make --version 2>/dev/null | grep '^GNU Make ' >/dev/null ; then
+echo "$as_me:$LINENO: checking whether ${MAKE-make} is GNU Make" >&5
+echo $ECHO_N "checking whether ${MAKE-make} is GNU Make... $ECHO_C" >&6
+if ${MAKE-make} --version 2>/dev/null | grep '^GNU Make ' >/dev/null ; then
         echo "$as_me:$LINENO: result: yes" >&5
 echo "${ECHO_T}yes" >&6
 else
Comment 1 Murray Cumming 2005-06-14 06:43:38 UTC
This must be a problem with autoconf or automake. Normally they handle this
fine. I'm sure you can make a simple test case for them. My examples here might
help: http://www.openismus.com/documents/linux/automake/automake.shtml#ExampleFiles
Comment 2 Murray Cumming 2005-08-01 10:20:11 UTC
Please do try a simple test case. This is almost certainly not a gtkmm bug.
Comment 3 Murray Cumming 2005-09-12 16:48:44 UTC
I'm likely to close this soon as it looks like a general autotools problem, 
and I'd expect many othere software builds to have the same problem.
Comment 4 Marek Rouchal 2005-09-19 15:31:04 UTC
The offending code does not come from autoconf/automake, but is part of the 
glibmm distro: glibmm-2.8.0/scripts/macros.m4:

dnl AL_PROG_GNU_MAKE(ACTION_NOT_FOUND)
dnl   Check for GNU make (no sun make)
dnl
AC_DEFUN([AL_PROG_GNU_MAKE],[
dnl 
dnl Check for GNU make (stolen from gtk+/configure.in)
AC_MSG_CHECKING(whether make is GNU Make)
if $ac_make --version 2>/dev/null | grep '^GNU Make ' >/dev/null ; then
        AC_MSG_RESULT(yes)
else
        AC_MSG_RESULT(no)
        if test "$host_vendor" = "sun" ; then
           $1
        fi
fi
])


It would work nicely if the one line above was changed to:

if ${MAKE-make} --version 2>/dev/null | grep '^GNU Make ' >/dev/null ; then
   ^^^^^^^^^^^^

-Marek
Comment 5 Murray Cumming 2005-09-27 05:36:46 UTC
Ah, many thanks.
Comment 6 Murray Cumming 2005-10-29 10:12:55 UTC
Applied. Thanks. I have no idea why the change is better (a ChangeLog entry
might have explained this to me.) but it does not seem to break anything.