GNOME Bugzilla – Bug 307314
Gradient Editor can be wider than GIMP_VIEWABLE_MAX_PREVIEW_SIZE
Last modified: 2008-01-23 19:42:55 UTC
Distribution/Version: FC3 Open Gradient Editor. Make it very wide. Notice that gradient is centred, but arrows are left-justified. Like this: http://loki.aceldama.com/stuff/gimp/gradient-editor-misalignment.png
The preview size is limited to 1024. We should probably drop this limitation since the only part of GIMP that really needs large previews (the gradient editor), needs even larger ones.
Shouldn't the gradient editor deal gracefully with the fact that the preview is not necessarily of the requested size?
I had a look at the code and while it seems desirable to deal with any preview size, it would add quite some complexity to already complex code. Might be easier to just increase the limit to a point where we don't get this problem any longer. What about increasing the limit to 4096?
Increasing priority to Urgent because this should be tried now if it is going to be done for 2.4, so that the results can get some testing.
Increasing the constant to 4096 will increase the heap size by 36 KB (see app/widgets/gimprender.c:gimp_render_setup_notify). That is probably tolerable.
I've gone for something in between. 2048 should be enough to avoid the problem. Bumping the bug to 2.6 and lowering priority. 2006-08-15 Sven Neumann <sven@gimp.org> * app/core/gimpviewable.h: increased GIMP_VIEWABLE_MAX_PREVIEW_SIZE to 2048 to workaround bug #307314.
The gradient editor doesn't use the pre-allocated buffer any longer. It is only used for the previews and even that is going to change soon. Closing as FIXED.