After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 306441 - [patch] make applet handles transparent
[patch] make applet handles transparent
Status: RESOLVED FIXED
Product: gnome-panel
Classification: Other
Component: panel
git master
Other All
: High enhancement
: ---
Assigned To: Panel Maintainers
Panel Maintainers
: 122509 124083 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2005-06-04 04:42 UTC by Allison Karlitskaya (desrt)
Modified: 2015-03-24 13:00 UTC
See Also:
GNOME target: ---
GNOME version: Unversioned Enhancement


Attachments
patch action (6.52 KB, patch)
2005-06-04 04:43 UTC, Allison Karlitskaya (desrt)
committed Details | Review
an exciting screencap. (174.28 KB, image/png)
2005-06-04 04:44 UTC, Allison Karlitskaya (desrt)
  Details

Description Allison Karlitskaya (desrt) 2005-06-04 04:42:48 UTC
Attached is a patch to make the handles on panel applets see-through.

This is accomplished by generalising the code that the menu bar uses for
transparency and moving it out of panel-menu-bar.c and into panel-background.c.  

A single call to this code was then added to panel-applet-frame.c (and the 2
calls from panel-menu-bar.c were changed for the new interface).
Comment 1 Allison Karlitskaya (desrt) 2005-06-04 04:43:22 UTC
Created attachment 47222 [details] [review]
patch action
Comment 2 Allison Karlitskaya (desrt) 2005-06-04 04:44:00 UTC
Created attachment 47223 [details]
an exciting screencap.
Comment 3 Vincent Untz 2005-06-06 20:40:21 UTC
*** Bug 122509 has been marked as a duplicate of this bug. ***
Comment 4 Vincent Untz 2005-06-06 20:53:06 UTC
*** Bug 124764 has been marked as a duplicate of this bug. ***
Comment 5 Vincent Untz 2005-06-06 20:53:13 UTC
*** Bug 124083 has been marked as a duplicate of this bug. ***
Comment 6 Vincent Untz 2005-06-06 20:57:04 UTC
Ryan: could you extend the patch so the handles of non-expanded panels have the
same feature? The code is in panel-toplevel.c.
Comment 7 Allison Karlitskaya (desrt) 2005-06-07 18:15:50 UTC
no. :)
Comment 8 David (djst) Tenser 2005-10-09 23:19:20 UTC
Any progress here? Will the patch make the edge handles of a non-expanded panel
are no longer opaque? 
Comment 9 Allison Karlitskaya (desrt) 2005-10-10 18:35:50 UTC
no. :)
Comment 10 David (djst) Tenser 2005-10-10 22:43:36 UTC
Less talk, more coding. At least that's my hope. :) And sorry for my bad grammar
in the previous comment.
Comment 11 Christian Neumair 2005-10-29 09:29:26 UTC
Are you still working on this one?
Comment 12 Allison Karlitskaya (desrt) 2005-10-29 15:59:23 UTC
no :)



seriously, though... it would be a lot of work to make the handles of the
non-expanded panels transparent.  too much work for such a small improvement,
imho.  let's just wait for composite.
Comment 13 Vincent Untz 2005-12-29 18:10:05 UTC
Thanks. Fixed in HEAD. It's not really beautiful with some themes, but that's better than nothing ;-)
Comment 14 David (djst) Tenser 2006-01-03 21:21:36 UTC
Any particular theme this works properly with? I tried with Clearlooks on Ubuntu Dapper (latest development packages) and the handles are now black.
Comment 15 Vincent Untz 2006-01-03 22:16:23 UTC
This is an issue with clearlooks, I think.
Comment 16 Allison Karlitskaya (desrt) 2006-01-03 22:56:48 UTC
i filed bug 325430 against clearlooks the other day and there is now a patch attached to the report which fixes it :)
Comment 17 John Keller 2008-02-29 11:13:19 UTC
(In reply to comment #12)
> seriously, though... it would be a lot of work to make the handles of the
> non-expanded panels transparent.  too much work for such a small improvement,
> imho.  let's just wait for composite.

With "real" composite being included "in the box" starting with Metacity in 2.22, could this bug be revisited for 2.24?

It would be great for the whole panel to be able to be made truly transparent when compositing is available, as done in Terminal. (Especially since the contents of windows that are slid underneath panels will show through, not a negligible benefit.)

Not hoping for an Apple-alike Dock, just hoping for more complete support for transparency throughout the desktop... :-)