After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 304874 - Win32: Cannot open Cyrillic filenames from command line
Win32: Cannot open Cyrillic filenames from command line
Status: RESOLVED FIXED
Product: Gnumeric
Classification: Applications
Component: General
1.5.x
Other Windows
: Normal normal
: ---
Assigned To: Jody Goldberg
Jody Goldberg
: 304873 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2005-05-20 14:50 UTC by Alexey Chupahin
Modified: 2005-05-27 10:38 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
proposed patch (1006 bytes, patch)
2005-05-26 06:40 UTC, Ivan Wong 		none Details | Review
proposed patch (2.67 KB, patch)
2005-05-27 10:13 UTC, Ivan Wong 		none Details | Review
proposed patch (for gnumeric) (1.26 KB, patch)
2005-05-27 10:38 UTC, Ivan Wong 		none Details | Review

Description Alexey Chupahin 2005-05-20 14:50:25 UTC 
Click any Excel file with cyrillic name (CP1251) leads to error
"C:\??????? ????.xls (invalid encoding):Invalid argument"

Please fix it; it is only thing to stop our migration from MS Office
Comment 1 Alexey Chupahin 2005-05-20 14:51:09 UTC 
Please fix it; it is only thing to stop our migration from MS Office
Comment 2 Andreas J. Guelzow 2005-05-20 16:33:14 UTC 
*** Bug 304873 has been marked as a duplicate of this bug. ***
Comment 3 Ivan Wong 2005-05-24 06:44:37 UTC 
Would you please attach a simple test file?
Comment 4 Morten Welinder 2005-05-24 13:35:03 UTC 
Ivan: I am not 100% sure, but he seems to be saying that when an xls file
has a cyrillic name (i.e., a non-ASCII name) then Gnumeric cannot read it.

Alex: is that the case?  Can you open them from inside Gnumeric?
Comment 5 Alexey Chupahin 2005-05-25 04:46:06 UTC 
Yes, this can be any file with cyrillic name; but I can open it inside
Gnumeric (GTK open file dialog). 
It is still importent because our users often open files from windows file explorer
Comment 6 Morten Welinder 2005-05-25 13:06:43 UTC 
I think I see the problem.  The utilities in goffice/goffice/utils/go-file.c
probably no longer work after glib changed the encoding it uses for filenames
on Win32.

Ivan: this should be fairly simple to debug starting with go_shell_arg_to_uri.
Comment 7 Ivan Wong 2005-05-26 06:40:15 UTC 
Created attachment 46891 [details] [review]
proposed patch

I have already fixed that yesterday but since my broadband service at home has
been terminated without any reason I was not able to post it until I am at
work.
Comment 8 Ivan Wong 2005-05-26 15:06:20 UTC 
patch commited
Comment 9 Ivan Wong 2005-05-27 10:13:54 UTC 
Created attachment 46937 [details] [review]
proposed patch

The previous patch only works partially.

Morten, as we disscused in IRC, you are right that we should use utf16 if we
are using NT-based OS so that we are able to open file (in NTFS parition) with
name that is not covered by the system codepage (e.g. codepage == big5,
Japanese file name).

g_locale_to_utf8() should be still used by win9x.
Comment 10 Ivan Wong 2005-05-27 10:38:54 UTC 
Created attachment 46939 [details] [review]
proposed patch (for gnumeric)