GNOME Bugzilla – Bug 304336
"Delete from trash" confirmation message is too long
Last modified: 2010-08-09 21:03:49 UTC
See: http://www.joelonsoftware.com/uibook/chapters/fog0000000062.html The "empty from trash" confirmation message is three lines long, in addition to the title. This seems unnecessarily long. I would suggest a shorter message, eg. Empty the trash? All items will be permanently lost. Other information:
imho this is a good situation, the user stucks. a moment to think about if he really wants to. btw. in firefox there is a 3 seconds time out on the install button, inlcuded in the "really install this extension" - dialog. I'd like this for unrecoverable actions like this one too.
We should really sort out what the appropriate label is. We currently have "Empty all of the items from the trash? If you choose to empty the trash, all items in it will be permanently lost. Please note that you can also delete them separately." I think Simons' proposal goes into the right direction, but is a bit too terse. IMHO we should use something like "If you empty the trash, all items in it will be permanently lost." as secondary message, since it conveys the information that this action is not recoverable.
Relevant part of HIG for a confirmation alert: http://library.gnome.org/devel/hig-book/stable/windows-alert.html.en#alerts-confirmation We can reword the dialogue to: Are you sure you want to empty all items from Trash ? All items will be permanently deleted and can not be restored. [ Cancel ] [ Empty Trash ]
Created attachment 165289 [details] [review] Better (shorter) text when emptying trash (#304336) Text based on vish comment
Review of attachment 165289 [details] [review]: ::: libnautilus-private/nautilus-file-operations.c @@ +1330,3 @@ } + prompt = f (_("Are you sure you want to empty all items from Trash?")); I don't see much gain in changing this primary message. @@ +1335,3 @@ prompt, + f(_("All items will be permanently deleted and " + "can not be restored.")), I'd say "and you will not be able to restore them.".
(In reply to comment #5) > > I don't see much gain in changing this primary message. The current Primary text in prompt we get for Permanent delete [shift+delete] is: Are you sure you want to permanently delete "Blahbla"? Changing the first line would make it consistent within Nautilus itself and in line with HIG. > > @@ +1335,3 @@ > prompt, > + f(_("All items will be permanently deleted and " > + "can not be restored.")), > > I'd say "and you will not be able to restore them.". Not sure why we have to make the line longer here. We already have the shorter line from HIG. :)
My preference would be for: 'Empty all items from trash? All items in the trash will be permanently deleted.' It's a good idea to have a short primary text. People need to be able to scan it quickly. Plus, 'Are you sure' is kinda redundant. As for the secondary text, 'you will not be able to restore them' is implied in 'permanently deleted', isn't it?
(In reply to comment #7) > > It's a good idea to have a short primary text. People need to be able to scan > it quickly. Plus, 'Are you sure' is kinda redundant. > Yup , Update to HIG required? ;)
(In reply to comment #7) > My preference would be for: > > 'Empty all items from trash? > > All items in the trash will be permanently deleted.' Should we capitalize as Trash ?
(In reply to comment #9) > (In reply to comment #7) > > My preference would be for: > > > > 'Empty all items from trash? > > > > All items in the trash will be permanently deleted.' > > Should we capitalize as Trash ? Yes. Good catch! 'Empty all items from Trash? All items in the Trash will be permanently deleted.'
Created attachment 167142 [details] [review] Better (shorter) text when emptying trash (#304336) Updated patch with new wording from aday and vish.
Review of attachment 167142 [details] [review]: Looks good; please commit to master. You should also notify i18n about the string change, as we did not yet branch gnome-2-32, so master is not freeze-free yet.
Comment on attachment 167142 [details] [review] Better (shorter) text when emptying trash (#304336) Pushed, closing as FIXED