GNOME Bugzilla – Bug 303930
Speech is same for Lower or Upper Case
Last modified: 2005-06-27 09:13:04 UTC
Please describe the problem: Whether keyboard "caps lock" On or Off, gnopernicus speech engine say the same thing. Should speech engine announce lower or upper case per setting or at least caps is locked or not ... ? This would be issues where case sensitive applications are applicable (i.e password, etc.) Setup: 1. Fedora Core 3 2. Gnopernicus 0.10.7 3. Gnome Panel 2.10.2 Steps to reproduce: 1. Bring up Gnopernicus, listen for speech 2. Bring up gnome terminal 3. With No "Caps Lock", type in any alphabets, listen 4. With "Caps Lock", type in any alphabets, listen Actual results: Same speech for both lower or upper case, no different Expected results: Need to be distinguished for lower or upper case Does this happen every time? yes Other information: tbd
Created attachment 46529 [details] [review] proposed patch
Comment on attachment 46529 [details] [review] proposed patch This patch adds "upper" string before any upper char in "char by char" and "military" modes.
RFE, not AP1. Marking AP2 (which is generous).
Created attachment 47748 [details] [review] Proposed patch Changed "upper" into "capital".
I suggest "cap" rather than capital for at least the English version, and a note to translators that this should be as brief a string as possible. "Cap" is what I've seen Windows screen readers so - you want this to be as brief as possible. Otherwise I think this is a fine patch.
Comment on attachment 47748 [details] [review] Proposed patch >Index: gnopernicus/speech/libsrs/srs-speech.c >=================================================================== >RCS file: /cvs/gnome/gnopernicus/speech/libsrs/srs-speech.c,v >retrieving revision 1.8 >diff -u -r1.8 srs-speech.c >--- gnopernicus/speech/libsrs/srs-speech.c 25 May 2005 12:01:05 -0000 1.8 >+++ gnopernicus/speech/libsrs/srs-speech.c 14 Jun 2005 10:22:03 -0000 >@@ -378,11 +378,11 @@ > index = srs_sp_letter_get_index_for_spell (letter); > > text = g_string_new (""); >-/* if (g_unichar_isupper (letter)) >+ if (g_unichar_isupper (letter)) > { >- g_string_append (text, _("upper")); >+ g_string_append (text, _("cap")); > g_string_append (text, " "); >- }*/ >+ } > if (index >= 0) > g_string_append (text, > tout->spelling == SRS_SPELLING_CHAR ?
Changed "capital" into "cap". Patch committed to CVS head.