After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 303803 - Add a common Save Confirmation dialogue
Add a common Save Confirmation dialogue
Status: RESOLVED OBSOLETE
Product: gtk+
Classification: Platform
Component: Widget: Other
2.6.x
Other All
: Normal enhancement
: Medium API
Assigned To: gtk-bugs
gtk-bugs
: 591661 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2005-05-11 14:35 UTC by Marc O'Morain
Modified: 2018-05-02 14:09 UTC
See Also:
GNOME target: ---
GNOME version: Unversioned Enhancement


Attachments
Source Code to add confirmation box (4.40 KB, text/plain)
2005-05-11 14:37 UTC, Marc O'Morain
Details
Header File to add confirmation box (1.34 KB, text/plain)
2005-05-11 14:38 UTC, Marc O'Morain
Details

Description Marc O'Morain 2005-05-11 14:35:59 UTC
 
Comment 1 Marc O'Morain 2005-05-11 14:37:20 UTC
Created attachment 46334 [details]
Source Code to add confirmation box
Comment 2 Marc O'Morain 2005-05-11 14:38:17 UTC
Created attachment 46335 [details]
Header File to add confirmation box
Comment 3 Marc O'Morain 2005-05-11 14:40:24 UTC
As suggested here:

http://mail.gnome.org/archives/gtk-devel-list/2005-May/msg00061.html

The attached code may need some love (I don't have access to a GNOME system to
build it on, and have never written any GTK code before).
Comment 4 Timothy Arceri 2013-06-22 10:21:17 UTC
*** Bug 591661 has been marked as a duplicate of this bug. ***
Comment 5 Matthias Clasen 2018-02-10 05:09:35 UTC
We're moving to gitlab! As part of this move, we are moving bugs to NEEDINFO if they haven't seen activity in more than a year. If this issue is still important to you and still relevant with GTK+ 3.22 or master, please reopen it and we will migrate it to gitlab.
Comment 6 Dave Malcolm 2018-02-10 13:00:41 UTC
Moving from NEEDINFO back to NEW, as I think this is still a reasonable RFE.  

For example gedit provides its own implementation of this:
https://github.com/GNOME/gedit/blob/master/gedit/gedit-close-confirmation-dialog.c

This seems like something that could be refactored and moved from gedit to a shared library, to avoid every app having to reimplement the wheel here.
Comment 7 Emmanuele Bassi (:ebassi) 2018-02-11 00:28:04 UTC
(In reply to Dave Malcolm from comment #6)
> Moving from NEEDINFO back to NEW, as I think this is still a reasonable RFE.
> 
> 
> For example gedit provides its own implementation of this:
> https://github.com/GNOME/gedit/blob/master/gedit/gedit-close-confirmation-
> dialog.c
> 
> This seems like something that could be refactored and moved from gedit to a
> shared library, to avoid every app having to reimplement the wheel here.

Thanks for your patience!

This will not happen for GTK+ 3.x — at most for GTK+ 4.0, and if only three or more applications decide to share the same code.

Additionally, you should provide a patch in the form of a file generated by `git format-patch`, `git bz`, or, better yet, as a merge request on https://gitlab.gnome.org/GNOME/gtk.

The attached files do not conform to the coding style of GTK, so they will need to be modified.

Finally, it's worth it to raise this bug with the GNOME design team, as they should be involved in a user-facing issue like this one.
Comment 8 GNOME Infrastructure Team 2018-05-02 14:09:49 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gtk/issues/248.