GNOME Bugzilla – Bug 302662
Dragging a link to toolbar doesn't recognize smart bookmark
Last modified: 2011-12-14 20:11:49 UTC
From http://galeon.sourceforge.net/bookmarks/browse.php?category=Programming, drag one of the smart bookmarks to the bookmark toolbar. The link won't be recognized as a smart bookmark. IRC log: <chpe> <a type="text/smartbookmark" href="http://www.c2.com/cgi/wiki?RecentChanges" rel="http://www.c2.com/cgi/wiki?search=%s" title="C2 Wiki"> <chpe> that's because dragging transfers the 'href' data, not the 'rel' data <chpe> so we have no way to know it's a smart bmk <reinouts> chpe: but when you bookmark it and _then_ put it on the tb, it does get an entry?! <chpe> I see no easy way to fix it (mozilla dnd is the horrors :) <reinouts> ouch <chpe> yes, bookmarking uses our code which extracts the smart link <chpe> maybe there is a way <chpe> text/_moz_htmlcontext <chpe> text/_moz_htmlinfo <chpe> text/html <chpe> the drag data includes those formats... maybe one of them has the info? <chpe> does someone have a tool to see all the _data_ from the drag (I have dnd-list which shows the _types_)
Confirming. I've found out that we get the required information in the drag if we request 'text/html' format. The response looks like this: <a type="text/smartbookmark" href="http://www.c2.com/cgi/wiki?RecentChanges" rel="http://www.c2.com/cgi/wiki?search=%s" title="C2 Wiki"> and it's in UTF-16.
Target: 1.8 -> 1.10 due to feature and UI freeze.
-> 1.12 due to feature and UI freeze.
Is it planned to accept a patch enabling smart bookmark D'n'D? Or shoud we wait until the history/bookmark/smartbookmark is rewritten. (I think that a fusion of those features is ongoing/being thought about.) [Heh, but if that's mozilla, /me runs away.]
I think this isn't worth the effort.
@Cyril: I don't think the rewrite of the history backend influences this bug.
We don't have a bookmarks bar anymore, so this is obsolete.