After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 302348 - patch to add gnome-screensaver support
patch to add gnome-screensaver support
Status: RESOLVED FIXED
Product: gnome-panel
Classification: Other
Component: panel
2.6.x
Other Linux
: High normal
: ---
Assigned To: Panel Maintainers
Panel Maintainers
Depends on:
Blocks: 302344
 
 
Reported: 2005-04-28 21:46 UTC by William Jon McCann
Modified: 2005-06-06 21:51 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch for head (3.37 KB, patch)
2005-04-28 21:47 UTC, William Jon McCann 		needs-work Details | Review
updated patch (8.32 KB, patch)
2005-05-04 19:11 UTC, William Jon McCann 		none Details | Review

Description William Jon McCann 2005-04-28 21:46:52 UTC 
Here is a patch to add gnome-screensaver support.  Should anyone ever need such
a thing...
Comment 1 William Jon McCann 2005-04-28 21:47:24 UTC 
Created attachment 45804 [details] [review]
patch for head
Comment 2 Mark McLoughlin 2005-05-03 10:52:30 UTC 
If we're going to commit this before gnome-screensaver is in the desktop
release, I want it to be able to run the gnome-screensaver stuff if its
installed and run the xscreensaver otherwise
Comment 3 William Jon McCann 2005-05-04 19:11:35 UTC 
Created attachment 46027 [details] [review]
updated patch

To do this cleanly I moved the all the screensaver command stuff into utils.  I
also set is_disabled on the action if the lock command is not available.

Does this look ok?
Comment 4 Vincent Untz 2005-06-06 21:51:28 UTC 
I committed a slightly modified version to HEAD. I'm not sure that passing
strings as argument to tell what we want to do is a good thing, but that's how
panel_applet_add_callback does right now, so...
Thanks!