After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 300957 - Please use a hyphen instead of an underscore, i.e "translator-credits".
Please use a hyphen instead of an underscore, i.e "translator-credits".
Status: RESOLVED FIXED
Product: gnome-calculator
Classification: Core
Component: general
unspecified
Other All
: Normal minor
: ---
Assigned To: Rich Burridge
Rich Burridge
Depends on:
Blocks:
 
 
Reported: 2005-04-17 15:06 UTC by Vincent van Adrighem
Modified: 2005-04-21 15:02 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Translator_Credits Patch... for Gcalc (1.52 KB, patch)
2005-04-19 13:29 UTC, Manoj
none Details | Review
Translator_Credits Gcalc Patch (1.52 KB, patch)
2005-04-19 13:33 UTC, Pradeep MN
none Details | Review
Gcal Patch (1.24 KB, patch)
2005-04-20 05:41 UTC, Pradeep MN
none Details | Review
Replaced underscore with hyphen and removed unnecessary strcmp (983 bytes, patch)
2005-04-20 11:19 UTC, Vincent van Adrighem
none Details | Review

Description Vincent van Adrighem 2005-04-17 15:06:10 UTC
/gcalctool/gtk.c:519
msgid "translator_credits"

Other information:
Some translation tools check that messages which have access keys in the
source also have access keys in the translation, and barf otherwise.
Obviously those tools will mistake this underscore for an access key.
Comment 1 Manoj 2005-04-19 13:29:59 UTC
Created attachment 45442 [details] [review]
Translator_Credits Patch... for Gcalc

I agreed with Vincent... here's the patch.. hopefully the idea behind...
Comment 2 Pradeep MN 2005-04-19 13:33:42 UTC
Created attachment 45443 [details] [review]
Translator_Credits Gcalc Patch

Sorry for as above.. my friend had logged in and i sent the patch in his
login.. Here's the same patch again... 

I agreed with Vincent... here's the patch.. hopefully the idea behind... Please
acknowledge
Comment 3 Vincent van Adrighem 2005-04-19 13:42:54 UTC
Well, not exactly. You can keep the underscores in those lines. I don't know
what happens if you change those things around. 

The line that needs changing is line 519, as I stated (very unclearly) in my
first post. It's this line:
    const gchar *translator_credits = _("translator_credits");
It should be something like this:
    const gchar *translator_credits = _("translator-credits");
Comment 4 Pradeep MN 2005-04-19 14:23:39 UTC
ya.. will checkout what happens..
Comment 5 Pradeep MN 2005-04-20 05:40:54 UTC
if we change to.. at 519 line

const gchar *translator_credits = _("translator-credits");

we dont get "Translated by tab". If thats ok.. then here's the patch.. if its ok
then fine.. else make it as fixed. Any views?
Comment 6 Pradeep MN 2005-04-20 05:41:36 UTC
Created attachment 45465 [details] [review]
Gcal Patch

Any comments?
Comment 7 Vincent van Adrighem 2005-04-20 11:19:34 UTC
Created attachment 45476 [details] [review]
Replaced underscore with hyphen and removed unnecessary strcmp

The credits only show up if they are translated. So, they should not appear in
the first place when you use an English locale. Tested it, and this works like
a charm.
Comment 8 Rich Burridge 2005-04-21 15:02:06 UTC
Thanks everyone. I've applied the last attached to CVS HEAD
and bumped the version number in configure.in to 5.6.11.
Look for a tarball next Monday for the GNOME 2.11.1 release.