GNOME Bugzilla – Bug 300547
gnome-vfs-daemon crash on fstab change
Last modified: 2018-08-17 13:51:51 UTC
edit /etc/fstab with an editor which moves the file for a short instant when you overwrite it with your changes, gnome-vfs-daemon crashes proposed patch (from the ubuntu package): 01_fstab_edit_crash.patch diff -Nur gnome-vfs2-2.10.0/libgnomevfs/gnome-vfs-volume-monitor-daemon.c gnome-vfs2-2.10.0.new/libgnomevfs/gnome-vfs-volume-monitor-daemon.c --- gnome-vfs2-2.10.0/libgnomevfs/gnome-vfs-volume-monitor-daemon.c 2004-12-14 17:23:33.000000000 +0100 +++ gnome-vfs2-2.10.0.new/libgnomevfs/gnome-vfs-volume-monitor-daemon.c 2005-03-17 12:01:07.245801992 +0100 @@ -718,6 +718,9 @@ mount = l->data; uri = gnome_vfs_get_uri_from_local_path (mount->mount_path); + if (uri == NULL) + continue; + drive = _gnome_vfs_volume_monitor_find_fstab_drive_by_activation_uri (volume_monitor, uri); if (drive != NULL) {
I can confirm this crasher. Thanks for your great debugging work :). We really should get this committed.
I already know about this crasher, but I am not so sure this is the way we want to fix it. That's why I didn't commit this one yet.
This patch is still used by Debian, see http://patch-tracker.debian.org/patch/series/view/gnome-vfs/1:2.24.4-1/01_fstab_edit_crash.patch
gnome-vfs got deprecated in 2008. gnome-vfs is not under active development anymore and had its last code changes in 2011. Its codebase has been archived: https://gitlab.gnome.org/Archive/gnome-vfs/commits/master gio (in glib) and gvfs are its successors. See https://developer.gnome.org/gio/stable/ch33.html and https://people.gnome.org/~gicmo/gio-migration-guide/ for porting info. Closing this report as WONTFIX as part of Bugzilla Housekeeping to reflect reality. Feel free to open a task in GNOME Gitlab if the issue described in this task still applies to a recent + supported version of glib/gio/gvfs. Thanks!