After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 300151 - [PATCH]ORBit2 fails to build from CVS if pkg-config-0.16.0 is installed
[PATCH]ORBit2 fails to build from CVS if pkg-config-0.16.0 is installed
Status: RESOLVED FIXED
Product: ORBit2
Classification: Deprecated
Component: general
2.10.x
Other All
: Normal normal
: ---
Assigned To: ORBit maintainers
ORBit maintainers
Depends on:
Blocks:
 
 
Reported: 2005-04-11 06:58 UTC by James Henstridge
Modified: 2005-04-11 10:35 UTC
See Also:
GNOME target: ---
GNOME version: 2.9/2.10


Attachments
orbit-config-change.patch (1.11 KB, patch)
2005-04-11 07:08 UTC, James Henstridge
none Details | Review

Description James Henstridge 2005-04-11 06:58:59 UTC
Please describe the problem:
The ORBit2 configure script fails to parse if the pkg.m4 from pkg-config >=
0.16.0 is picked up.

Steps to reproduce:
1. install pkg-config 0.16.0
2. check out ORBit2 from CVS
3. run ORBit2's autogen.sh script


Actual results:
The following error is printed:
configure.in:118: error: possibly undefined macro: PKG_CONFIG_MIN_VERSION
      If this token and others are legitimate, please use m4_pattern_allow.
      See the Autoconf documentation.


Expected results:
ORBit2 is configured successfully.

Does this happen every time?
yes

Other information:
The pkg.m4 macro file in pkg-config 0.16.0 contains the following code:
  m4_pattern_forbid([^_?PKG_[A-Z_]+$])
  m4_pattern_allow([^PKG_CONFIG(_PATH)?$])

In effect, this reserves the PKG_* and _PKG_* namespaces for its use in shell
code (except for $PKG_CONFIG and $PKG_CONFIG_PATH).  This feature is done to
detect bugs where unknown macros are used in a configure script and end up
unexpanded.

ORBit2's configure script defines a shell variable $PKG_CONFIG_MIN_VERSION,
which causes the error.  The two fixes are:
 1. rename the variable (eg. $xPKG_CONFIG_MIN_VERSION)
 2. add the line m4_pattern_allow([^PKG_CONFIG_MIN_VERSION$])

The first option is probably a better choice.
Comment 1 James Henstridge 2005-04-11 07:08:39 UTC
Created attachment 45122 [details] [review]
orbit-config-change.patch

Simple patch to fix the problem
Comment 2 Christian Kirbach 2005-04-11 07:33:44 UTC
Raising priority. Adding PATCH keyword.
Comment 3 Michael Meeks 2005-04-11 09:36:24 UTC
James - please do feel free to commit anything you like to ORBit2 ;-)
Comment 4 James Henstridge 2005-04-11 10:35:07 UTC
Okay, the patch has been applied to both the HEAD and gnome-2-10 branches, which
should cover pretty much anyone building from CVS, and having pkg-config-0.16.0
installed.