GNOME Bugzilla – Bug 2845
AisleRiot (card game): auto-finish game and card show..
Last modified: 2012-01-31 23:27:10 UTC
Package: gnome-games Version: 1.0.51 Severity: wishlist Playing solitare (Klondike), once the stock & waste piles are empty and there are no more cards face-down in the Tableau section (7 piles), the rest of the game could be played automatically (since otherwise it's just a matter of double-clicking in all piles until nothing left). Also, it would be nice if there would be a nice card show (similar to windows solitare) when you win the game. -Don Beusee ------- Bug moved to this database by debbugs-export@bugzilla.gnome.org 2001-01-27 16:31 ------- This bug was previously known as bug 2845 at http://bugs.gnome.org/ http://bugs.gnome.org/show_bug.cgi?id=2845 Originally filed under the gnome-games product and general component. Unknown version 1.0.x in product gnome-games. Setting version to the default, "unspecified". The original reporter (dbeusee@us.oracle.com) of this bug does not have an account here. Reassigning to the exporter, debbugs-export@bugzilla.gnome.org. Reassigning to the default owner of the component, bugmeister@canvas.gnome.org.
I don't know if anybody will feel like implementing this, but it might be fun to see. Perhaps I'll start a project of the week like Havoc used to do, since I've got plenty of fun tasks here in bugzilla.
Well, somebody else did it for me, and I just haven't gotten back to bugs since then. I'll try to forward this on to them.
We should have a keyword for "fun little patch for a newbie developer".
isn't that what easy-fix is for? Also, it has been circa 3 years, no one has even started working on this. How long till we close this as a WONTFIX
.......how about now?
No, actually not now. I intend fixing both of these eventually. Although I probably won't have an auto-play feature, just a way to drag a pile to the foundation and have it automatically distributed amongst the piles. The fancy ending may or may not happen, but the current ending is a little sudden with a dialog just popping up. The reason it has been left for four years is that people look at scheme and run screaming. As a result aisleriot accumulated a lot of bugs that had to be looked at before enhancements could be considered.
Created attachment 45799 [details] [review] quick patch for autoplay in klondike I don't know if this helps, but here's a patch that auto-plays cards to the foundations in Klondike (activated by double-clicking on a foundation). Pretty much all this does is simulate double-clicks until nothing happens.
In Klondike automatically playing to the foundation is a bad idea. Like the freecell auto-player it needs to consider whether the card is still useful down on the tableau. There is a simple criteria that guarantees it is OK: if both cards that are one rank down and of the opposite suit are on the foundation, then it is OK. It may also be OK in other situations, but this is best left up to the players judgement (yes, Klondike actually has an element of skill). Hmmm, this bug seems quite simple to fix now I put it that way.
To clarify, the patch makes it play any cards it can to the foundation only immediately after you double-click a foundation. It doesn't do anything without user intervention, and it doesn't prevent a player from doing anything. If a player doesn't want to play some cards that he could, he can do it the normal way. This is, as far as I know, how autoplay normally works. If it's done completely automatically (so that if I uncover a card, and it can be safely played, it is played immediately), I'd worry about two things: -Without animations, wouldn't this be a little difficult to detect? -It should be possible to undo a play to the foundation without undoing the move that made it possible to safely play the card.
OK, I see. The double-clicking idea seems like a really good one. It removes the unexpectedness of auto-play but also makes the tedious moves a lot less tedious. Discovery is not good, but it is a power user feature. Also, it fits into a nice unused space in the interface. I will try the patch out later then.
I have finally tried it out. The behaviour feels good so I have applied the patch to CVS. Since I have no intention of coding in some special effects at the end of the game I think we can finally declare this bug fixed! Only five years in the solving.
This bug is being reassigned to the "general" component so we can close the aisleriot bugzilla component. Apologies for the mass email!