After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 272676 - Saved filter rule can't be modified if it is selected with GOK.
Saved filter rule can't be modified if it is selected with GOK.
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: Mailer
unspecified
Other All
: Normal normal
: ---
Assigned To: Harry Lu
Evolution QA team
Depends on:
Blocks: 271192
 
 
Reported: 2005-02-17 09:32 UTC by Harry Lu
Modified: 2005-02-18 05:33 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch 1.0 (1.36 KB, patch)
2005-02-17 09:54 UTC, Harry Lu 		none Details | Review

Description Harry Lu 2005-02-17 09:32:13 UTC 
Steps to reproduce:
1. Launch GOK and Evolution, and go to mail conponent.
2. Ensure there is at least one filter rule available.
3. Select Menus->Tools->Filters->UI Grab->Rule name in GOK, and select one 
saved filter rule.
4. Click back->UI Grab.

Expected result:
The rule is selected. And "the edit rule dialog should popup" or "the
Edit, Remove, Up and Down buttons should be activated"

Actual result:
Rule is selected, but Edit, Remove, Up and Down buttons are not activated 
after you select one and no edit dialog popups.
Comment 1 Harry Lu 2005-02-17 09:41:17 UTC 
When gok selects a cell, it will try to activate its default action. 
For gtktreeview's cell, the default action is calling 
gtk_tree_view_row_activated().

In rule-editor.c, the "row-activated" signal's handler is function 
double_click().  However, this function doesn't check whether this is 
a row selected. It just check "re->current".

This works for normal mouse and keyboard users since in function 
cursor_changed(), the "re->current" is set there. But for gok users, 
cursor_changed won't be called.

I will provide a patch soon.
Comment 2 Harry Lu 2005-02-17 09:54:36 UTC 
Created attachment 44803 [details] [review]
patch 1.0
Comment 3 Not Zed 2005-02-18 05:14:10 UTC 

*** This bug has been marked as a duplicate of 272285 ***
Comment 4 Not Zed 2005-02-18 05:15:18 UTC 
sorry, pasted into the wrong box :(
Comment 5 Harry Lu 2005-02-18 05:33:18 UTC 
patch committed.