After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 256899 - disable/enable button in settings redundant
disable/enable button in settings redundant
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: general
2.12.x
Other All
: Normal minor
: Future
Assigned To: Milan Crha
Evolution QA team
: 273337 331155 (view as bug list)
Depends on:
Blocks: 324810 327508 327510
 
 
Reported: 2004-04-13 07:29 UTC by Jakub Steiner
Modified: 2013-09-13 00:57 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed patch for bug 256899 (4.65 KB, patch)
2006-04-16 08:24 UTC, chaya 		rejected Details | Review
proposed evo patch (4.93 KB, patch)
2007-11-19 11:53 UTC, Milan Crha 		committed Details | Review

Description Jakub Steiner 2004-04-13 07:29:30 UTC 
Some widgets use a checkbox to select from a list of optional items
(Headers in Mail Preferences, Autocompletion). 

Elsewhere in preferences a regular button is used in addition to that. It
changes its label/behaviour and loses a mnemonic after pushing (it's not a
toggle button). I suggest we have a consistent interface and get rid of
this redundant button. 

It is used in the following tabs:

* Mail Accounts
* Calendar and Tasks > Free/Busy Publishing
Comment 1 Jakub Steiner 2004-04-13 09:47:43 UTC 
The button is also included in the Spell Checking tab in Composer
Preferences.
Comment 2 JP Rosevear 2005-02-03 05:38:38 UTC 
The button is gone from the spell checking tab now.
Comment 3 André Klapper 2005-04-27 14:51:46 UTC 
*** Bug 273337 has been marked as a duplicate of this bug. ***
Comment 4 André Klapper 2005-04-27 14:52:23 UTC 
talking about the mail accounts: the toggle button on the right also misses a
mnemonic. one cannot disable an account in the list (=with the checkbox) by
keyboard (only workaround: hitting tab until focus arrives on the toggle
button), so this is also an accessibility/keynav issue.
remove the enable/disable *button* and but up/down buttons to sort/order the
accounts there, would solve bug 272875.
Comment 5 André Klapper 2005-07-19 18:17:58 UTC 
as discussed with nags, changing component to "Misc" to get rid of the UI 
component, also reassign to Misc-assignee. adding UI keyword.
Comment 6 Calum Benson 2005-07-28 10:39:05 UTC 
Apologies for any spam... cc'ing usability-maint on all Evolution usability
bugs. Filter on EVO-USABILITY-SPAM to ignore.
Comment 7 André Klapper 2005-08-27 12:52:08 UTC 
still valid in 2.3.8, punting target to 2.5 due to ui freeze
Comment 8 André Klapper 2006-02-14 22:31:26 UTC 
*** Bug 331155 has been marked as a duplicate of this bug. ***
Comment 9 chaya 2006-04-16 08:24:20 UTC 
Created attachment 63625 [details] [review]
Proposed patch for bug 256899

Hope this patch fixes this bug
Comment 10 Calum Benson 2006-04-26 17:07:33 UTC 
Apologies for spam... ensuring Sun a11y folks are cc'ed on all current accessibility bugs.
Comment 11 André Klapper 2006-06-14 14:13:17 UTC 
removing old target milestone.
Comment 12 Srinivasa Ragavan 2007-08-23 12:47:52 UTC 
UI Freeze. Even otherwise the patch is invalid.

patching file em-account-prefs.c
patch: **** malformed patch at line 34: static void
Comment 13 Gilles Dartiguelongue 2007-08-24 12:26:05 UTC 
given the date at which it was submitted I guess it's normal :)
anyway, I'll have a look at updating it.
Comment 14 Milan Crha 2007-11-19 11:53:29 UTC 
Created attachment 99325 [details] [review]
proposed evo patch

for evolution;

just reworked Chaya's patch to let work on actual sources, so removing Enable/Disable button from Mail Accounts.
Comment 15 Srinivasa Ragavan 2007-11-22 05:19:16 UTC 
Milan, fine. Just test and commit to head only.
Comment 16 Milan Crha 2007-11-22 07:03:26 UTC 
Committed to trunk. Committed revision 34562.