GNOME Bugzilla – Bug 255973
Contact preview waste space and cosmetic correction
Last modified: 2011-02-16 07:22:56 UTC
the contact preview layout use a lot of place to display information : 1°) the breaking space between section (eg : work and personnal is too big) 2°) the layout uses vertical instead of horizontal, and waste a lot of space . it oblige to scroll down to see the end of the preview. 3°) there is some useless breaking space at the end of the preview. 4°) the preview seems to be blank, perhaps some tables around the text could make the preview more beautiful. I attach a screenshot.
Created attachment 43467 [details] a screenshot of the different point
Sorry for the spam, I set the bug to cosmetic
changing component to "Contacts" to get rid of the UI component, also reassigning as discussed with nags... adding UI keyword.
Apologies for any spam... cc'ing usability-maint on all Evolution usability bugs. Filter on EVO-USABILITY-SPAM to ignore.
*** Bug 254629 has been marked as a duplicate of this bug. ***
*** Bug 319245 has been marked as a duplicate of this bug. ***
removing old 2.5 target milestone and retargetting to future - sorry.
Created attachment 180315 [details] [review] Patch for adapting content of preview to orientation This patch provides HTML code generator for horizontally-oriented preview pane.
Created attachment 180394 [details] Actual view with a patch applied - contact.png This is what I see for my "Complete Contact". The vertical view is fine, but the classical is kinda strange, still. a) the point 3) still applied from the comment #0, see the space between WorkCountry and Note section. It's too large b) I would keep "Contact, Complete" text, the bold one, always on one line, it's its name, so keep it full-width. It will also cause the other columns being on the same line, not "Email" being below "Work". c) the email type (grayed "(Work)", "(Home)", ...) may not wrap from the email address. d) the Note should cover whole width, not only the first column. I know my test contact doesn't have a picture set, neither IM protocols, but it's otherwise pretty complete. Please fix the above, and try to follow coding style guideline from [1] and resubmit the patch. Thanks in advance. (I see // comments in the code, no spaces between function names and the open bracket, and when you have parameters on two lines, then its indent doesn't match - though there is no need to wrap parameters in these cases, from my point of view). [1] http://projects.gnome.org/evolution/patch.shtml
Created attachment 180814 [details] [review] Fixed patch All issues mentioned by Milan are fixed in this patch.
Created attachment 180820 [details] [review] Little tunning to the previous patch Just small fix of the previous patch - proper freeing in accum_* functions, fixed missing title in contacts list and minor cosmetic changes of code.
This looks better, apart of missing chunk from modules/addressbook/e-book-shell-content.c, which is only in the first patch. Strange. The last two things, I believe: a) The "Notes" part seems to be rendered always, but it should be rendered only if any note is set on the contact and no other time. b) Do not set "nowrap" on contact name (the file_as/full_name string part), this one holds whole row and can wrap. Imagine some quite long institution name, with larger words it can split on more lines.
Created attachment 180904 [details] [review] Fix issues from comment #12 This revision fixes issues mentioned in comment #12
Thanks, that's it. I changed only two things there, one was forgotten space (really little tiny) and this one: >+ str = e_contact_get_const (contact, E_CONTACT_NOTE); >+ if (strlen(str) == 0) the 'if' statement to: >+ if (!str || !*str) because the function can return NULL and there is no need to count "letters" to ask whether the string is empty or not.
Created commit 005bb4e in evo master (2.91.90+)