GNOME Bugzilla – Bug 254923
The image in a contact could be scaled to a sane size
Last modified: 2013-09-10 14:00:51 UTC
Setting the image in a contact from a uncropped picture, which is what you'd get from a camera, for example, ends up with a huge pic in the preview pane for that contact. Maybe the image could be scaled into a sane size? The definition of sane in this context is, of course, left as an exercice for the reader.
Seems to scale fine in current build... Can you try it with a more recent Evolution and let me know how goes?
it does NOT scale in 2.2.2, note that this is about the contact *preview pane*. retargetting.
Created attachment 49757 [details] [review] resize patch It prompts for resize and stores the reqd size
Commited to cvs
As pointed out by Åsmund Skjæveland on gnome-i18n list: The added error message needs some work from i18n side. At first it should be marked for translation, and there should be no trailing space.
Created attachment 50131 [details] [review] proposed change
Looks fine. Can you commit it asap?
Committed.
having a contact with a picture set, i wanted to verify that bug 254923 has been fixed by srini. choosing the contact from the list and having the preview pane open, i already saw that the photo wasn't displayed and only the normal "red cross on a paper" icon that gnome normally shows if a picture has been removed or isn't found. i don't know which photo i chose; perhaps i've really moved it to another directory or anything else. so i wanted to choose a new one. but after opening the contact editor and clicking on the picture icon (it was displayed as if i would have never ever set a photo for that contact, evolution freezes. this is evolution-2.3.7.0.200508170145-0.snap.novell.11.1 on suse9.3. if i try to set a picture on a contact i hadn't set a picture before to, the same happens (same stacktrace too). :-( andre@embrace:~> gdb evolution GNU gdb 6.3 Copyright 2004 Free Software Foundation, Inc. GDB is free software, covered by the GNU General Public License, and you are welcome to change it and/or distribute copies of it under certain conditions. Type "show copying" to see the conditions. There is absolutely no warranty for GDB. Type "show warranty" for details. This GDB was configured as "i586-suse-linux"...Using host libthread_db library "/lib/tls/libthread_db.so.1". (gdb) run Starting program: /opt/gnome/bin/evolution [Thread debugging using libthread_db enabled] [New Thread 1097789056 (LWP 10827)] [New Thread 1105783728 (LWP 10840)] adding hook target 'source' [New Thread 1113504688 (LWP 10842)] [New Thread 1115605936 (LWP 10843)] (evolution:10827): Gdk-CRITICAL **: gdk_gc_set_foreground: assertion `GDK_IS_GC (gc)' failed [New Thread 1117707184 (LWP 10846)] [Thread 1117707184 (LWP 10846) exited] (evolution:10827): libebook-CRITICAL **: e_contact_get_const: assertion `field_id >= 1 && field_id <= E_CONTACT_LAST_SIMPLE_STRING' failed (evolution:10827): libebook-CRITICAL **: e_contact_get_const: assertion `field_id >= 1 && field_id <= E_CONTACT_LAST_SIMPLE_STRING' failed (evolution:10827): libebook-CRITICAL **: e_contact_get_const: assertion `field_id >= 1 && field_id <= E_CONTACT_LAST_SIMPLE_STRING' failednew dimensions = (48,48) initial setting of an image. no scaling scale = 1 Program received signal SIG33, Real-time event 33. [Switching to Thread 1115605936 (LWP 10843)] 0xffffe410 in ?? () (gdb) thread apply all bt
+ Trace 62568
Thread 2 (Thread 1105783728 (LWP 10840))
Thread 1 (Thread 1097789056 (LWP 10827))
The program is running. Exit anyway? (y or n) y
Oh. This looks like the same gnome-vfs hang. Andre, just try opening any fileselector in evo this hang will happen. R-Click on attachments also hang. If so its some another bug. Can you please check it ?
srini: ah, good to know. yeah, it's the same gnome-vfs hang. is it filed anywhere so i can mark bugs as duplicates (e.g. my bug 314096)? closing this again, going to verify this after gnome-vfs hang has been fixed.
running evolution-2.3.8.0.200508260453-0.snap.novell.11.1, i get the question pop up "The image you have selsected is large. Do you want to resize and store it?". if i choose "no", the contact editor window becomes read-only and everything is greyed out. i *can* close it, but it takes a few seconds... if i choose yes, it becomes a small one (48x48px or whatever the shell told me), but when i saw the question for the first time, i asked myself "will my original picture be made smaller or just a copy of it stored in the addressbook database?" perhaps there should be a hint "The original image will not be changed/altered." or something like that. but perhaps i'm a user who just tries too hard to be a stupid user sometimes... :-) anyway, verifying this is fixed.