After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 239170 - void function should not has a 'return' keyword
void function should not has a 'return' keyword
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: Contacts
pre-1.5 (obsolete)
Other All
: Normal enhancement
: ---
Assigned To: evolution-addressbook-maintainers
Evolution QA team
Depends on:
Blocks: 239034
 
 
Reported: 2003-03-06 07:30 UTC by philip zhao
Modified: 2013-09-10 13:55 UTC
See Also:
GNOME target: ---
GNOME version: Unversioned Enhancement

Attachments
patch for the addressbook part (not full to fix this bug, but most neccessary) (3.68 KB, patch)
2003-03-11 08:32 UTC, philip zhao 		none Details | Review
another patch for filter/rule-editor.c (773 bytes, patch)
2003-03-20 07:02 UTC, Henry Jia 		none Details | Review
patch to this bug(merge of the pre-two) (4.44 KB, patch)
2003-03-20 07:13 UTC, philip zhao 		none Details | Review

Description philip zhao 2003-03-06 07:30:41 UTC 
Evolution has some void funtion but with a return at the end of the
function.
    Forte will error on this condition.

    The list of refering files:
                    ~/evolution/camel/camel-index.c
                    ~/evolution/camel/camel-session.c
                    ~/evolution/camel/camel-store-summary.c
                    ~/evolution/filter/filter-element.c
                    ~/evolution/filter/filter-editor.c
                    ~/evolution/addressbook/backend/pas/pas-backend.c 

How often does this happen? 

Always.

Additional Information:

We will add a patch which delete the unuseful 'return' of these function soon.
Comment 1 Jeffrey Stedfast 2003-03-06 14:52:01 UTC 
mailer parts are already fixed in CVS
Comment 2 philip zhao 2003-03-11 08:21:25 UTC 
~/evolution/camel/camel-index.c
~/evolution/camel/camel-session.c
~/evolution/camel/camel-store-summary.c
~/evolution/filter/filter-element.c
~/evolution/filter/filter-editor.c

have worked well.

~/evolution/addressbook/backend/pas/pas-backend.c
still have a dozen of lines of same question exests.

While the newly added file 
~/filter/rule-editor.c
has two same questions.
Comment 3 philip zhao 2003-03-11 08:32:46 UTC 
Created attachment 42101 [details] [review]
patch for the addressbook part (not full to fix this bug, but most neccessary)
Comment 4 Gerardo Marin 2003-03-11 21:34:54 UTC 
Philip: please submit the patch to evolution-patches list
Comment 5 Henry Jia 2003-03-20 06:57:18 UTC 
Philip, have you sent the patch to evolution-patches@ximian.com?
Comment 6 Henry Jia 2003-03-20 07:02:52 UTC 
Created attachment 42148 [details] [review]
another patch for filter/rule-editor.c
Comment 7 Henry Jia 2003-03-20 07:03:55 UTC 
Philip, please merge these two patches into one file and send it to 
evolution-patches@ximian.com.
Comment 8 philip zhao 2003-03-20 07:13:38 UTC 
Created attachment 42149 [details] [review]
patch to this bug(merge of the pre-two)
Comment 9 Patton Gao 2003-03-25 10:20:00 UTC 
File ~/evolution/addressbook/backend/pas/pas-backend.c still has this 
issue. There're 12 positions in this file. (Mar 25 trunk)
Comment 10 Chris Toshok 2003-03-26 23:52:31 UTC 
commited fix for the addressbook portion.  closing this.