GNOME Bugzilla – Bug 235194
The contact list name can be set to empty from minicard view
Last modified: 2004-09-29 20:42:52 UTC
Please fill in this template when reporting a bug, unless you know what you are doing. Description of Problem: The contact-list name is prevent from empty if you create or edit it from the contact-list-editor dialog. However, you can just set the name field empty from the minicard view and it really take effect. It is a bug, though some extent trivial Steps to reproduce the problem: 1. open the contact and create a contact list 2. edit the minicard of that list, and delete all the content in name field 3. Actual Results: You will find the list name is really be set to be empty and if you open the contact-list editor dialog, the name field is still empty there. Expected Results: Evolution should detect that the name field is set empty or not. If so it should give some warning and correct the mistake. How often does this happen? Additional Information:
I am now working on solve this problem. Will post a patch later.
Created attachment 41828 [details] [review] A proof of concept
In the attempt to fix this bug, I have meet some trouble. The question is that the items' sent its "changed" signal to the e-minicard, and the later just records every change one by one. This is not an efficient way at first, because it must reset the data with each user action. It should provide a mechanism to save the final result at once by some point(for eg, move focus or press Enter). Secondly, in the current mechanism, we cannot tell if the empty string is the final result or temporary status. The proof-of-concept is trying to prevent the empty string, however, if a user wanna delete the whole name and give a new one, he will become angry... I am still seeking for better solution.
Focus change is the best approach here - we can't use Enter because there's nothing to tell the UI that a field is single line or not.
This bug is blocked by #35294, and I have written a patch for that. I will write a new patch for this when that one is resolved.
as discussed on irc due to a design change in evo1.5.x this one can be called fixed because editing the card directly is not possible anymore in evolution1.5-1.5.8.0.200405281008-0.snap.ximian.8.1.