GNOME Bugzilla – Bug 233669
Empty card can be created!
Last modified: 2013-09-10 14:03:17 UTC
Please fill in this template when reporting a bug, unless you know what you are doing. Description of Problem: When I try to create a card, I find the "save and close" button is disable at first and will turn to be enabled if some content are added into the card. It is a good idea to prevent empty card be created. I find, however, if I input something first and then delete all (for correcting error or so) the button will not turn back to disabled. I compare it with the contact list editor dialog, and find the later is better for taking more into account. When new a contact list, it uses "List Name" field as the necessary item, thus if it is empty, the save and close bottun is disabled. Steps to reproduce the problem: 1. Open the "Contacts" view. 2. Click to set focus on a card, then try "Ctrl-X" or "DEL" 3. Actual Results: No response Expected Results: The hot keys should work as defined. How often does this happen? Always Additional Information: This problem still exists in 1.2 release.
Created attachment 41717 [details] [review] proposed patch
Sorry for mistakes in description. Here is the correct version Steps to reproduce the problem: 1. Click to open the "New Contact" dialog box 2. Input something in any field and then delete all 3. Actual Results: The 'Save and Close" button become enalbed and will not switch back to disable even when all input is deleted Expected Results: This button should be disable if the input is all cleared. How often does this happen? Always
This bug is still in 1.2.0 release. Thus I write a patch based on the consideration in the contact list editor. The patch checks if the name or e-mail is added before setting the "save and close" button status, of course we can choose any other fields as "necessary" items for a card, but personally I think these 2 fields are most important ... Any idea?
Still valid in 1.5
*** This bug has been marked as a duplicate of 258056 ***