After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 172815 - GCC 4 issues with parser code
GCC 4 issues with parser code
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other Linux
: Normal normal
: 0.9.x
Assigned To: GStreamer Maintainers
GStreamer Maintainers
: 301097 310106 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2005-04-06 14:37 UTC by Jeffrey C. Ollie
Modified: 2005-07-19 10:51 UTC
See Also:
GNOME target: ---
GNOME version: 2.9/2.10


Attachments
fixes fwrite warn_unused_result (339 bytes, patch)
2005-04-06 14:38 UTC, Jeffrey C. Ollie
none Details | Review

Description Jeffrey C. Ollie 2005-04-06 14:37:10 UTC
Distribution/Version: Fedora Core 4 Test 1

Compile gstreamer BRANCH-GSTREAMER-0_8 with GCC 4 and you get the following:

 gcc -DHAVE_CONFIG_H -I. -I. -I../.. -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64
-pthread -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/libx
ml2 -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -fno-common -g -Wall -Werror -DGS
T_DISABLE_DEPRECATED -I../.. -O2 -g -pipe -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -
m32 -march=i686 -mtune=pentium4 -fasynchronous-unwind-tables -MT libgstparse_la-
grammar.tab.lo -MD -MP -MF .deps/libgstparse_la-grammar.tab.Tpo -c grammar.tab.c
 -o libgstparse_la-grammar.tab.o >/dev/null 2>&1
cc1: warnings being treated as errors
lex._gst_parse_yy.c: In function '_gst_parse_yylex':
parse.l:144: warning: ignoring return value of 'fwrite', declared with attribute
 warn_unused_result

Company suggested a patch that fixes this problem. (will attach)
Comment 1 Jeffrey C. Ollie 2005-04-06 14:38:36 UTC
Created attachment 39750 [details] [review]
fixes fwrite warn_unused_result
Comment 2 Benjamin Otte (Company) 2005-04-06 14:46:42 UTC
This is really a bug in flex, so someone should
- file a bug against flex.
- explain in the patch why the "#define ECHO" is needed, so it doesn't get lost.

Other than that I'd wait until the warnings gcc4 reports are finalized before
committing this patch.
Comment 3 Jeffrey C. Ollie 2005-04-06 14:59:52 UTC
I'll add some comments about need in the patch after the meeting i have coming
up in a few minutes.
Comment 4 Tim-Philipp Müller 2005-04-18 20:28:56 UTC
*** Bug 301097 has been marked as a duplicate of this bug. ***
Comment 5 Christian Fredrik Kalager Schaller 2005-04-19 08:03:14 UTC
I mailed Flex maintainer Vern Paxson today pointing him to this bugzilla entry.
Comment 6 Ronald Bultje 2005-04-20 07:40:41 UTC
Jeffrey, Benjamin, I'm totally confused about the echo, so can either of you add
a patch explaining why it's there so this can be applied?
Comment 7 Andy Wingo 2005-07-16 12:31:12 UTC
Jeffrey, is this still a problem for you?
Comment 8 Jeffrey C. Ollie 2005-07-16 13:56:37 UTC
I haven't been building CVS lately, as all of the fixes I had been looking for
in CVS have been rolled into releases.
Comment 9 Andy Wingo 2005-07-16 16:09:13 UTC
*** Bug 310106 has been marked as a duplicate of this bug. ***
Comment 10 Andy Wingo 2005-07-16 16:10:02 UTC
Reopening, we still get things like bug #310106
Comment 11 Andy Wingo 2005-07-19 10:51:36 UTC
Applied patch similar to attachment #1 [details], but actually printing out something.
Seems to fix Christian's problem from bug #310106.