After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 172352 - small code cleanup in gedit-languages-manager.c::string_to_tag_style
small code cleanup in gedit-languages-manager.c::string_to_tag_style
Status: RESOLVED FIXED
Product: gedit
Classification: Applications
Component: general
git master
Other All
: Normal normal
: ---
Assigned To: Gedit maintainers
Gedit maintainers
Depends on:
Blocks:
 
 
Reported: 2005-04-01 13:41 UTC by Benoît Dejean
Modified: 2006-04-26 18:37 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch against HEAD (619 bytes, patch)
2005-04-01 13:41 UTC, Benoît Dejean 		committed Details | Review
rewrite against new_mdI (2.75 KB, patch)
2005-04-01 13:42 UTC, Benoît Dejean 		none Details | Review
updated patch (3.18 KB, patch)
2005-07-23 10:39 UTC, Paolo Borelli 		committed Details | Review

Description Benoît Dejean 2005-04-01 13:41:06 UTC 
I'm attaching patches.
Comment 1 Benoît Dejean 2005-04-01 13:41:35 UTC 
Created attachment 39554 [details] [review]
patch against HEAD
Comment 2 Benoît Dejean 2005-04-01 13:42:04 UTC 
Created attachment 39556 [details] [review]
rewrite against new_mdI
Comment 3 Paolo Borelli 2005-07-23 10:39:07 UTC 
Created attachment 49608 [details] [review]
updated patch

here is an updated patch for new_mdi, apart from some minor stylisitc changes
it fixes a problem in the previous patch: if the first goto error is hit a null
pointer was freed.


[the leak itself has been plugged on HEAD, so the patch is only for new_mdi]
Comment 4 Benoît Dejean 2005-12-27 11:10:26 UTC 
it's OK to g_free(NULL)
Comment 5 Paolo Maggi 2006-03-04 14:32:19 UTC 
May be it is time to commit this patch.

pbor?
Comment 6 Paolo Borelli 2006-03-04 17:13:47 UTC 
well, it's just code cleanup (the leak was fixed) and since it has weited till today I think it can wait some more given that we are so near to the release...
Comment 7 Paolo Maggi 2006-03-04 17:23:16 UTC 
The leak was not fixed.
I just fixed it in CVS HEAD (2.13.x).

We can apply the code cleanup patch as soon as we branch for 2.14.
Comment 8 Paolo Maggi 2006-04-26 14:25:58 UTC 
Benoît: could you please apply the code cleanup to CVS HEAD?
Comment 9 Benoît Dejean 2006-04-26 17:04:29 UTC 
give me some time to rework the patch, it doesn't apply anymore.
Comment 10 Benoît Dejean 2006-04-26 18:37:10 UTC 
done.