After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 172087 - FOCUSED state is contained by the new active child in case of 'active-descendant-changed' event from an unfocused table
FOCUSED state is contained by the new active child in case of 'active-descend...
Status: RESOLVED FIXED
Product: atk
Classification: Platform
Component: gail
unspecified
Other Linux
: Normal normal
: ---
Assigned To: padraig.obriain
padraig.obriain
Depends on:
Blocks:
 
 
Reported: 2005-03-30 10:41 UTC by Oana Serb
Modified: 2005-04-25 11:19 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
proposed patch (748 bytes, patch)
2005-03-30 11:07 UTC, remus draica 		needs-work Details | Review
revised patch (1.13 KB, patch)
2005-04-07 12:42 UTC, Dragan Sarbut 		needs-work Details | Review
reworked patch (1.09 KB, patch)
2005-04-13 14:15 UTC, remus draica 		committed Details | Review

Description Oana Serb 2005-03-30 10:41:10 UTC 
In this case, any cell from the table which fired the
'active-descendant-changed' event, shouldn't have the FOCUSED state.
This bug depends on bug #171232.
Comment 1 bill.haneman 2005-03-30 10:43:46 UTC 
I don't understand this bug report.  Can you explain further?  I think that
firing active-descendant-changed is perfectly legal for unfocussed tables.
Comment 2 remus draica 2005-03-30 11:05:47 UTC 
In bug #171232 is described a case where the change of current selected child in
a table will change also the current selected child in other table. Both table
fire "active-descendant-changed" event. Both new active children have FOCUSED
state. Only first should.
Comment 3 remus draica 2005-03-30 11:07:39 UTC 
Created attachment 39428 [details] [review]
proposed patch
Comment 4 bill.haneman 2005-03-30 11:34:12 UTC 
Comment on attachment 39428 [details] [review]
proposed patch

Thanks Remus, this looks correct.
Comment 5 bill.haneman 2005-03-30 11:36:05 UTC 
on reflection, I think that a better solution would be to add ATK_STATE_ACTIVE
to these cells, instead of ATK_STATE_FOCUSSED; that would prevent the case of
having multiple objects with 'FOCUSSED' state.  The patch would be very similar
to the one Remus has already proposed, substituting ATK_STATE_ACTIVE.
Comment 6 bill.haneman 2005-04-06 09:00:39 UTC 
Is a revised patch appropriate?  If so please provide one.
Comment 7 Dragan Sarbut 2005-04-07 12:42:36 UTC 
Created attachment 39799 [details] [review]
revised patch

This patch is the same patch but it contains the ATK_STATE_ACTIVE instead of
ATK_STATE_FOCUSED
Comment 8 bill.haneman 2005-04-08 16:06:11 UTC 
please commit the patch and close the bug.
Comment 9 remus draica 2005-04-13 14:15:05 UTC 
Created attachment 45215 [details] [review]
reworked patch
Comment 10 Oana Serb 2005-04-25 11:19:15 UTC 
Patch committed to CVS head.