After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 171044 - Audio files for sound events should be user selectable
Audio files for sound events should be user selectable
Status: RESOLVED FIXED
Product: gossip
Classification: Deprecated
Component: General
unspecified
Other Linux
: Normal enhancement
: ---
Assigned To: Gossip Maintainers
Gossip Maintainers
: 164307 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2005-03-20 23:40 UTC by Kai Weber
Modified: 2005-05-14 15:23 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Makes sound for events selectable (2.73 KB, patch)
2005-04-17 00:36 UTC, Jonatan Magnusson 		none Details | Review
Sound event list (218 bytes, text/plain)
2005-04-17 00:38 UTC, Jonatan Magnusson 		  Details
Combines two previous patches and adds some. (1.97 KB, patch)
2005-05-10 23:22 UTC, Martyn Russell 		none Details | Review
File was not included in last patch. (222 bytes, application/octet-stream)
2005-05-10 23:24 UTC, Martyn Russell 		  Details

Description Kai Weber 2005-03-20 23:40:28 UTC 
I would like to change the audio file for the various events. I think it would
fit well into the "Sound Events" tab of the "Sound Preferences" from the GNOME menu.
Comment 1 Jonatan Magnusson 2005-04-17 00:36:20 UTC 
Created attachment 45338 [details] [review]
Makes sound for events selectable

This patch makes Gossip use the gnome sound event mechanism.

It installs sound files in <datadir>/sounds/gossip instead of <datadir>/gossip.


It also enable sounds for contacts going online and offline.
Comment 2 Jonatan Magnusson 2005-04-17 00:38:23 UTC 
Created attachment 45339 [details]
Sound event list

This attachment is needed for the above patch and should be put in 
/etc/sound/events by install script.
Comment 3 Jonatan Magnusson 2005-04-17 00:42:32 UTC 
... and of course should be named gossip.soundlist ...
Comment 4 Mikael Hallendal 2005-04-17 17:13:40 UTC 
Marking with PATCH keyword, will take a look at this as soon as possible.
Comment 5 Martyn Russell 2005-05-10 23:22:23 UTC 
Created attachment 46310 [details] [review]
Combines two previous patches and adds some.

* Added INTL support.
* Only included the trigger header (not all of libgnome's headers).

I have got the system regcognising Gossip in the sound preferences, but I am
not getting any sounds from the gnome_trigger_do() that is called? Maybe I have
something set up wrong this end or there is a step missing in the patch? I get
the gtk-event sounds OK.

This needs resolving before committing.
Comment 6 Martyn Russell 2005-05-10 23:24:25 UTC 
Created attachment 46311 [details]
File was not included in last patch.

* Prepended "_" to "description" to make sure it is translated.
Comment 7 Martyn Russell 2005-05-12 21:31:35 UTC 
*** Bug 164307 has been marked as a duplicate of this bug. ***
Comment 8 Jonatan Magnusson 2005-05-14 12:37:27 UTC 
Martyn: I had the same problem with everything working but still no sound. I
could not find anything my patch missed doing according to the documentation.
But when I restarted gnome it started working as it should and I've not had any
problem since.
Comment 9 Martyn Russell 2005-05-14 13:55:34 UTC 
I will test restarting GDM and see how I go.
Comment 10 Martyn Russell 2005-05-14 15:23:46 UTC 
From my investigation into this, when you change the preferences or install the
sound file it takes a restart of gdm for reflections to show up in Gossip (using
Gnome 2.8 on FC3).  This might be fixed in Gnome 2.10?

Marking as fixed, at least now the sounds are configurable!