After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 168731 - Floppy icon is not localized
Floppy icon is not localized
Status: RESOLVED FIXED
Product: gnome-vfs
Classification: Deprecated
Component: Other
cvs (head)
Other All
: High normal
: ---
Assigned To: Christian Neumair
Christian Neumair
Depends on:
Blocks:
 
 
Reported: 2005-02-28 07:07 UTC by Takao Fujiwara
Modified: 2005-05-08 13:04 UTC
See Also:
GNOME target: ---
GNOME version: 2.9/2.10

Attachments
patch for libgnomevfs/gnome-vfs-volume-monitor-daemon.c (1.08 KB, patch)
2005-02-28 07:08 UTC, Takao Fujiwara 		none Details | Review
Proposed patch (against HEAD). (8.94 KB, patch)
2005-05-02 08:36 UTC, Christian Neumair 		needs-work Details | Review
Additional bits. (5.79 KB, patch)
2005-05-07 13:20 UTC, Christian Neumair 		none Details | Review
Patch I am going to commit to CVS. (15.07 KB, patch)
2005-05-08 12:48 UTC, Christian Kellner 		committed Details | Review

Description Takao Fujiwara 2005-02-28 07:07:58 UTC 
The desktop icons; 'floppy', 'cdrom' are not localized on SuSE 9.x with GNOME 2.6.

I remember gnome-vfs used get_drive_name api at SuSE 8.x with GNOME 2.4 but now
gnome-vfs uses modify_volume_name_for_display api.

I'm attaching the patch to localize icon names.
Comment 1 Takao Fujiwara 2005-02-28 07:08:57 UTC 
Created attachment 38037 [details] [review]
patch for libgnomevfs/gnome-vfs-volume-monitor-daemon.c

i attached the patch.
Comment 2 Christian Neumair 2005-05-02 08:33:05 UTC 
Thanks for your efforts.
I can verify that this is still an issue, but I think your patch does the wrong
thing. The get_drive_name should in theory return a correctly localized name,
but it doesn't, possibly for i18n header breakage.
Comment 3 Christian Neumair 2005-05-02 08:36:19 UTC 
Created attachment 45925 [details] [review]
Proposed patch (against HEAD).

This patch ports gnome-vfs to gi18n-lib.h. It makes
libgnomevfs/gnome-vfs-i18n.h obsolete. After applying it, installing the
library, killing all daemons and vfs clients you should see correct i18n
results.
Comment 4 Christian Kellner 2005-05-07 13:14:00 UTC 
Looking good, but you seem to have forgotten that there is also a modules dir! I
also have see it in the doc/Makefile.am. Can you fix that? Thanks! Great work!
Comment 5 Christian Neumair 2005-05-07 13:20:32 UTC 
Created attachment 46129 [details] [review]
Additional bits.

Should be applies in addition to the last patch. Thanks for your hints
Christian!
Comment 6 Christian Kellner 2005-05-08 12:48:14 UTC 
Created attachment 46161 [details] [review]
Patch I am going to commit to CVS.

Just a all-in-one version of Manny's patch.
Comment 7 Christian Kellner 2005-05-08 13:04:21 UTC 
Commited the patch to cvs HEAD. It seems to fix the bug here. Please test and if
it doesnt fix it reopen this bug. Thanks everybody!