After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 168384 - regex for Since: is too strict
regex for Since: is too strict
Status: RESOLVED FIXED
Product: gtk-doc
Classification: Platform
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gtk-doc maintainers
gtk-doc maintainers
Depends on:
Blocks:
 
 
Reported: 2005-02-24 12:45 UTC by Sven Neumann
Modified: 2005-03-03 13:21 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
only strip leading and trailing whitespace of the Since: symbol (760 bytes, patch)
2005-02-24 12:46 UTC, Sven Neumann 		accepted-commit_now Details | Review

Description Sven Neumann 2005-02-24 12:45:10 UTC 
In GIMP we use "Since: GIMP 2.2" to mark the API version. Just using "Since:
2.2" as GTK+ does, turned out to be confusing when people work with both the
GIMP and GTK+ API docs when writing plug-ins.

Unfortunately though, the regex which is used in gtkdoc-mkdb to generate the
role attribute of the indexterm is rather strict and only matches "GIMP",
stripping off the actual version number. As a result we can not generate an
index of new symbols using role-profiling.

Applying a very simple change to gtkdoc-mkdb fixes this problem and makes gtkdoc
a lot more useful to us (and probably for other projects as well). I'll attach a
patch against CVS in the hope that you will apply it.
Comment 1 Sven Neumann 2005-02-24 12:46:33 UTC 
Created attachment 37895 [details] [review]
only strip leading and trailing whitespace of the Since: symbol
Comment 2 Matthias Clasen 2005-02-24 13:47:14 UTC 
Looks good to me.
Comment 3 Sven Neumann 2005-02-25 13:42:36 UTC 
Does that mean that I should commit the change to CVS or am I waiting for one of
the gtk-doc hackers to do that?
Comment 4 Matthias Clasen 2005-02-25 15:15:10 UTC 
comitting it should be fine
Comment 5 Sven Neumann 2005-02-26 01:25:41 UTC 
2005-02-26  Sven Neumann  <sven@gimp.org>

        * gtkdoc-mkdb.in (MakeIndexterms): allow space in Since: keywords,
        only strip leading and trailing whitespace (bug #168384).
Comment 6 Damon Chaplin 2005-03-03 13:21:58 UTC 
Thanks. I assume this is fixed then.