After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 168202 - Full window isn't visible with right panels.
Full window isn't visible with right panels.
Status: RESOLVED FIXED
Product: gnome-blog
Classification: Other
Component: Blog Applet
0.9.x
Other Linux
: High normal
: ---
Assigned To: GNOME blog maintainers
GNOME blog maintainers
Depends on:
Blocks:
 
 
Reported: 2005-02-22 23:08 UTC by Michael O'Reilly
Modified: 2005-05-20 17:41 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Let applet follow Fitt's Law and position window like the clock (5.57 KB, patch)
2005-05-20 14:32 UTC, Olav Vitters
committed Details | Review

Description Michael O'Reilly 2005-02-22 23:08:31 UTC
Version details: 0.8.1 build from src.rpm on FC3
Distribution/Version: FC 3

Set your panel properties to have the panel on the right
edge of your screen (i.e. not the left, top or bottom edges).

Click on 'blog'. Now that 1/3rd of the window is now buried beneath
the blog window, and there are no handles to move it out from under
to a visible position. If your panel is set to 96 pixels wide, you can't
access some of the buttons. 

Workaround is to move the panel, but on my 16x9 screen, a bottom panel is a
large chunk of screen realestate.
Comment 1 Olav Vitters 2005-05-19 22:22:48 UTC
Hrm.. only works for me with top/bottom panels, (left doesn't work either).

The clock applet has a lot of code to handle the popup, maybe that can be used.

See position_calendar_popup in clock.c.
Comment 2 Olav Vitters 2005-05-20 11:26:52 UTC
I ported it, but it doesn't fix it completely. When the vertical panel is very
wide the window is placed next to the toggle button. However, this toggle button
is smaller than the panel width. I tried before to get the width/height of the
panel, but that isn't easy to solve (button is centered).

I think I now understand what the clock does to ensure this. The clock is also a
toggle button and the clock ensures that the button width is the full panel size
if you have a vertical panel.

For top/bottom panels the button is always the maximum height possible. Doing
that should ensure the popup can be placed correctly (I think).
Comment 3 Olav Vitters 2005-05-20 14:32:36 UTC
Created attachment 46676 [details] [review]
Let applet follow Fitt's Law and position window like the clock

Ok, to make the widget expand only a
self.set_applet_flags(gnome.applet.EXPAND_MINOR) was needed.

Patch contains a port of position_calendar_popup from clock.c to position the
window. I needed the current orientation of the panel in aligned_window.py. For
this I passed the get_orient function to AlignedWindow. Not as nice as I'd
like, but workable enough to be able to test the patch.
Comment 4 Olav Vitters 2005-05-20 17:41:15 UTC
Committed on HEAD.

Marking FIXED.