GNOME Bugzilla – Bug 168117
[PATCH] better transparency support for the window list applet
Last modified: 2015-03-24 13:00:52 UTC
As per discussion in Bug 167932 this is a small patch to the window list applet to make it use the wnck_tasklist_set_button_relief() function. The semantics are: For "no background (system theme)" panels, everything remains the same. For pixmap/colour/transparent panels, the button relief is removed.
Created attachment 37764 [details] [review] the patch
*** Bug 73744 has been marked as a duplicate of this bug. ***
Ryan: I'd prefer if you could modify your patch to use a switch, so it's the same code as in workspace-switcher.c. I find it's more readable with the switch ;-)
Created attachment 37943 [details] [review] updated. updated patch, as per request. there are some lines >80 chars. i couldn't come up with a reasonable way to avoid it so i went by the convention used elsewhere in the same file.
Pending the approval of bug 167932 by the release team is this one also OK?
As I said in bug #167932, it might be better to enable this only for pixmap backgrounds if there's approval for the other patch.
OK. I'll write the release team and ask them what they think.
Seems it will wait for 2.12.
Can I commit these to HEAD?
Will this be in for 2.12 ? The relevant API has been added to libwnck in bug #167932.
maybe that could go for GNOME 2.12.1?
+1 :)
Committed. Ryan: something must have changed somewhere since it only works for plain color backgrounds and not for image backgrounds. Could you take a look at it and open a bug against the right component (probably lubwnck or GTK+)? Thanks
Ah, it doesn't work with Glider but works with Simple. Might be related to bug #165608
I've never set pixmaps for my panels -- always just use solidcolour and turn the transparency way up. I just tried to set a pixmap background and the results were fantastically bad. The entire panel is visually corrupted -- not just the applet. What's the story here?