GNOME Bugzilla – Bug 167948
epiphany-extension: configure is hardwired to seach only for epiphany-1.2.x, which leads to a compilation failure
Last modified: 2005-05-28 14:11:00 UTC
Version details: 0.0.6 & 0.0.6.1 Distribution/Version: YDL-4.0.1 && garmone-2.9.91.1 configure uses pkg_config to search for required libraries. The major version numbers for the required libraries are hard wired into code. ... EPIPHANY_REQUIRED=1.2.1 LIBXML_REQUIRED=2.6.0 LIBGLIB_REQUIRED=2.4.0 LIBGTK_REQUIRED=2.4.0 ... if $PKG_CONFIG --atleast-pkgconfig-version $PKG_CONFIG_MIN_VERSION; then echo "$as_me:$LINENO: checking for \ libxml-2.0 >= $LIBXML_REQUIRED \ libglade-2.0 \ glib-2.0 >= $LIBGLIB_REQUIRED \ gmodule-2.0 \ gtk+-2.0 >= $LIBGTK_REQUIRED \ epiphany-1.2 >= $EPIPHANY_REQUIRED" >&5 My system has both ephipany-1.2.7 [installed under /usr] and epiphany1-5.6 [installed under /opt/garnome]. The build fails with ephipany-1.2.7: ccache gcc -DHAVE_CONFIG_H -I. -I. -I.. -DORBIT2=1 -pthread -I/opt/garnome/include/libxml2 -I/opt/garnome/include/libglade-2.0 -I/opt/garnome/include/gtk-2.0 -I/opt/garnome/lib/gtk-2.0/include -I/opt/garnome/include/atk-1.0 -I/opt/garnome/include/pango-1.0 -I/usr/X11R6/include-I/usr/include/freetype2 -I/usr/include/freetype2/config -I/opt/garnome/include/glib-2.0 -I/opt/garnome/lib/glib-2.0/include -I/opt/garnome/include/libgnomeui-2.0 -I/opt/garnome/include/bonobo-activation-2.0 -I/opt/garnome/include/libbonoboui-2.0 -I/opt/garnome/include/orbit-2.0 -I/opt/garnome/include/gnome-vfs-2.0 -I/opt/garnome/lib/gnome-vfs-2.0/include -I/opt/garnome/include/gnome-vfs-module-2.0 -I/opt/garnome/include/gconf/2 -I/opt/garnome/include/libgnome-2.0 -I/opt/garnome/include/libgnomecanvas-2.0 -I/opt/garnome/include/libart-2.0 -I/opt/garnome/include/libbonobo-2.0 -I/usr/include/epiphany-1.2 -DSHARE_DIR=\"pkgdatadir\" -DG_DISABLE_DEPRECATED -DGDK_DISABLE_DEPRECATED -DGTK_DISABLE_DEPRECATED -DGDK_PIXBUF_DISABLE_DEPRECATED -DGNOME_DISABLE_DEPRECATED -I/opt/garnome/include -g -I/opt/garnome/include -L/opt/garnome/lib-O2 -pipe -MT ephy-beagle-extension.lo -MD -MP -MF .deps/ephy-beagle-extension.Tpo -c ephy-beagle-extension.c -fPIC -DPIC -o .libs/ephy-beagle-extension.o ephy-beagle-extension.c:34:37: epiphany/ephy-extension.h: No such file or directory ephy-beagle-extension.c:35:41: epiphany/ephy-embed-persist.h: No such file or directory ephy-beagle-extension.c:36:33: epiphany/ephy-shell.h: No such file or directory ephy-beagle-extension.c:37:32: epiphany/ephy-node.h: No such file or directory ephy-beagle-extension.c:38:37: epiphany/ephy-bookmarks.h: No such file or directory ephy-beagle-extension.c:51: error: syntax error before '*' token ... To work around this problem I manually edited configure to search for epiphany-1.5.x.
the epiphany extension is essentially unmaintained at this point, so we'd take patches to fix this stuff up.
Created attachment 38699 [details] [review] fix epiphany extension build This patch brings the Epiphany extension up to date with Epiphany 1.6+.
Created attachment 39293 [details] [review] updated patch This uses the right Epiphany API to create a EphyEmbedPersist.
Before we go ahead and use this, what is the overhead of using the epiphany extension over the EpiphanyBackend which is in dashboard. The EpiphanyBackend in dashboard indexes ephy's cache. That way we would drop the ephiphany extension dependency.
The Epiphany backend in dashboard only takes the bookmarks and history entries from the on-disk files. This extension instead sends the pages to beagle as the user browses to them. That's the same thing that the firefox extension does; so I don't see why you would include that one but not the Epiphany extension.
Christian, this looks fine to commit. Thanks for taking the time on this.
Committed.