After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 167319 - smart bookmarks should replace all instances of %s in the url
smart bookmarks should replace all instances of %s in the url
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: Bookmarks
unspecified
Other All
: Normal minor
: ---
Assigned To: Epiphany Maintainers
Marco Pesenti Gritti
Depends on:
Blocks:
 
 
Reported: 2005-02-14 01:26 UTC by Raphael Slinckx
Modified: 2005-04-24 12:39 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
ephy-smart.patch (1003 bytes, patch)
2005-03-17 00:18 UTC, Raphael Slinckx 		none Details | Review
ephy-smart.patch (928 bytes, patch)
2005-03-17 00:34 UTC, Raphael Slinckx 		none Details | Review

Description Raphael Slinckx 2005-02-14 01:26:12 UTC 
When creating a smart bookmark where there are multiple occurences of the %s
seach term, epiphany should replace them all and not only the first one, this
happens for exemple when searching on the gentoo bugzilla:

http://bugs.gentoo.org/buglist.cgi?bug_status=UNCONFIRMED&bug_status=NEW&bug_status=ASSIGNED&bug_status=REOPENED&bug_status=RESOLVED&bug_status=VERIFIED&bug_status=CLOSED&field0-0-0=product&type0-0-0=substring&value0-0-0=%s&field0-0-1=component&type0-0-1=substring&value0-0-1=%s&field0-0-2=short_desc&type0-0-2=substring&value0-0-2=%s&field0-0-3=status_whiteboard&type0-0-3=substring&value0-0-3=%s


Other information:
Comment 1 Raphael Slinckx 2005-03-17 00:18:44 UTC 
Created attachment 38817 [details] [review]
ephy-smart.patch

Here is the fix, this is my first piece of C code for a gnome project, so i
don't know if it's ok, or not.

I noticed that you do a return if fail thing if the replacement fails, here the
t1 string will get copied at least once in the string buffer, but i don't think
this is a major issue..

Now i can enjoy having a smart bookmark for all bugzillas, that require 4
occurrences of the search string, eeek !
Comment 2 Raphael Slinckx 2005-03-17 00:34:16 UTC 
Created attachment 38818 [details] [review]
ephy-smart.patch

And now with correct indentation, and in the cvs root
Comment 3 Christian Persch 2005-04-24 12:39:13 UTC 
Fixed in cvs HEAD, thanks for the patch!