After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 167170 - Avoid markup in gnome-applets message
Avoid markup in gnome-applets message
Status: RESOLVED FIXED
Product: gnome-applets
Classification: Other
Component: Disk Mounter (drivemount)
git master
Other All
: High normal
: 2.12
Assigned To: gnome-applets Maintainers
gnome-applets Maintainers
Depends on:
Blocks: 150905
 
 
Reported: 2005-02-12 15:12 UTC by Christian Rose
Modified: 2005-06-12 05:01 UTC
See Also:
GNOME target: ---
GNOME version: 2.9/2.10

Attachments
Proposed patch (2.31 KB, patch)
2005-03-17 03:41 UTC, Michael Terry 		committed Details | Review

Description Christian Rose 2005-02-12 15:12:52 UTC 
#: drivemount/drive-button.c:495
#, c-format
msgid ""
"<span weight=\"bold\" size=\"larger\">Cannot execute '%s'</span>\n"
"%s"

*Please* don't include markup in translateable messages. Move the markup outside
of the gettext call.
http://developer.gnome.org/doc/tutorials/gnome-i18n/developer.html#avoid-markup
Comment 1 Danielle Madeley 2005-02-12 15:30:15 UTC 
Confirming this. Marking for G12.
Comment 2 Michael Terry 2005-03-17 03:41:06 UTC 
Created attachment 38827 [details] [review]
Proposed patch

This patch uses a new GtkMessageDialog function that handle markup for us.  It
also cleans up a couple other strings that had unnecessary formatting text.
Comment 3 Michael Terry 2005-03-17 03:43:32 UTC 
I should mention that I actually didn't test this, since I couldn't get the
dialog to appear.  Please look it over carefully, though there aren't many changes.

Bumping priority.
Comment 4 Michael Terry 2005-03-17 03:47:52 UTC 
Just tested it.  It looks good to me.
Comment 5 Danielle Madeley 2005-03-20 05:24:19 UTC 
This is clear to commit to HEAD after we branch.
Comment 6 Danielle Madeley 2005-06-12 05:01:16 UTC 
2005-06-12  Davyd Madeley  <davyd@madeley.id.au>

        * drive-button.c: Avoid markup in gnome-applets message. Closes
          #167170.