After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 167061 - RFE: Improve reliability ( + patch )
RFE: Improve reliability ( + patch )
Status: RESOLVED FIXED
Product: gwget
Classification: Deprecated
Component: general
unspecified
Other Linux
: Normal enhancement
: ---
Assigned To: David Sedeño Fernández
David Sedeño Fernández
Depends on:
Blocks:
 
 
Reported: 2005-02-11 13:11 UTC by Ivan Yosifov
Modified: 2005-03-19 17:18 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch1 (7.69 KB, patch)
2005-02-11 13:12 UTC, Ivan Yosifov
none Details | Review
Weird effect (30.39 KB, image/jpeg)
2005-02-14 22:16 UTC, David Sedeño Fernández
  Details
patch2 (11.56 KB, patch)
2005-02-15 15:30 UTC, Ivan Yosifov
committed Details | Review
remember_more.patch (1.35 KB, patch)
2005-03-16 20:42 UTC, Ivan Yosifov
committed Details | Review

Description Ivan Yosifov 2005-02-11 13:11:43 UTC
Currently if gwget is terminated abnormally , it looses all new downloads. This
because downloads are write to gconf only on normal exit. The pruposed patch
changes that.
Comment 1 Ivan Yosifov 2005-02-11 13:12:25 UTC
Created attachment 37341 [details] [review]
patch1
Comment 2 Ivan Yosifov 2005-02-11 13:13:53 UTC
Changelog ( from the patch ): 
> 2005-02-11  Ivan Yosifov <ivan@yosifov.net>
> 
> 	* src/main_window_cb.c: minor tidying
> 	
> 	* src/main.c,
> 	  src/gwget_data.c
> 	  include/gwget_data.h : Moved gwget_pref initialziation code from main(),
> 	  	        	 to a new function - gwget_init_pref , declared in
> 			         gwget_data.h , defined in gwget_data.c , called in
> 	  			 main()
> 				 
> 	* src/main_window.c,
> 	  include/main_window.h: split gwget_quit() into two functions , namely:
> 			         gwget_remember_window_size_and_position() and
> 			         gwget_remember_downloads()
> 				 
> 	* src/gwget_data.c: call gwget_remember_downloads() in
> 			    gwget_data_start_download(). This way we won't
> 			    loose track of the downloads if gwget is
> 			    terminated abnormally ( power surges , hardware
> 			    failiures... )
> 
> 	* src/main_window.c: call gwget_remember_window_size_and_position on
> 			     configure-events. 
> 			     We update the download list on change , so why not update
> 			     window size on resize (or move) ? :)
> 
Comment 3 David Sedeño Fernández 2005-02-14 22:16:00 UTC
Created attachment 37477 [details]
Weird effect

I have applied the patch and have this effect when resizing the main window. I
didn't look at the patch very close, throught.

Have you this behaviour?

BTW, Can you please use diff -u for the patchs? It's more easy to read.
Comment 4 Ivan Yosifov 2005-02-15 04:24:58 UTC
>> Have you this behaviour?

Yes I have , strange I did not notice it. I will investigate this later today (
too early to think clear :) ).

>> BTW, Can you please use diff -u for the patchs? It's more easy to read.

Ofcourse :) I am a newbie when it comes to handling patches , please remind me
if I forget it again.
Comment 5 Ivan Yosifov 2005-02-15 15:30:57 UTC
Created attachment 37494 [details] [review]
patch2

I attach an updated version of the patch. Should fix the weired effect. The
problem was I did not return FALSE from a signal handler.
Comment 6 David Sedeño Fernández 2005-02-16 19:42:07 UTC
Comment on attachment 37494 [details] [review]
patch2

Works great. Checked into CVS.

Thanks a lot!
Comment 7 Ivan Yosifov 2005-03-16 20:42:55 UTC
Created attachment 38804 [details] [review]
remember_more.patch

Call remember_downloads() in a few more places.
Comment 8 David Sedeño Fernández 2005-03-19 17:18:33 UTC
Checked in cvs.

Thanks Ivan!