GNOME Bugzilla – Bug 167061
RFE: Improve reliability ( + patch )
Last modified: 2005-03-19 17:18:33 UTC
Currently if gwget is terminated abnormally , it looses all new downloads. This because downloads are write to gconf only on normal exit. The pruposed patch changes that.
Created attachment 37341 [details] [review] patch1
Changelog ( from the patch ): > 2005-02-11 Ivan Yosifov <ivan@yosifov.net> > > * src/main_window_cb.c: minor tidying > > * src/main.c, > src/gwget_data.c > include/gwget_data.h : Moved gwget_pref initialziation code from main(), > to a new function - gwget_init_pref , declared in > gwget_data.h , defined in gwget_data.c , called in > main() > > * src/main_window.c, > include/main_window.h: split gwget_quit() into two functions , namely: > gwget_remember_window_size_and_position() and > gwget_remember_downloads() > > * src/gwget_data.c: call gwget_remember_downloads() in > gwget_data_start_download(). This way we won't > loose track of the downloads if gwget is > terminated abnormally ( power surges , hardware > failiures... ) > > * src/main_window.c: call gwget_remember_window_size_and_position on > configure-events. > We update the download list on change , so why not update > window size on resize (or move) ? :) >
Created attachment 37477 [details] Weird effect I have applied the patch and have this effect when resizing the main window. I didn't look at the patch very close, throught. Have you this behaviour? BTW, Can you please use diff -u for the patchs? It's more easy to read.
>> Have you this behaviour? Yes I have , strange I did not notice it. I will investigate this later today ( too early to think clear :) ). >> BTW, Can you please use diff -u for the patchs? It's more easy to read. Ofcourse :) I am a newbie when it comes to handling patches , please remind me if I forget it again.
Created attachment 37494 [details] [review] patch2 I attach an updated version of the patch. Should fix the weired effect. The problem was I did not return FALSE from a signal handler.
Comment on attachment 37494 [details] [review] patch2 Works great. Checked into CVS. Thanks a lot!
Created attachment 38804 [details] [review] remember_more.patch Call remember_downloads() in a few more places.
Checked in cvs. Thanks Ivan!