After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 166632 - support vertical menubars
support vertical menubars
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: GtkMenu
2.6.x
Other All
: Normal enhancement
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks: 141702
 
 
Reported: 2005-02-08 06:25 UTC by Matthias Clasen
Modified: 2011-02-04 16:18 UTC
See Also:
GNOME target: ---
GNOME version: Unversioned Enhancement


Attachments
add an orientation property to GtkMenuBar (15.21 KB, patch)
2005-02-08 06:26 UTC, Matthias Clasen
none Details | Review
a screenshot (16.14 KB, image/png)
2005-02-09 18:49 UTC, Matthias Clasen
  Details

Description Matthias Clasen 2005-02-08 06:25:25 UTC
This would make vertical panels less monstrous
Comment 1 Matthias Clasen 2005-02-08 06:26:32 UTC
Created attachment 37143 [details] [review]
add an orientation property to GtkMenuBar
Comment 2 Federico Mena Quintero 2005-02-09 18:41:39 UTC
And now that Pango supports rotation... :)
Comment 3 Matthias Clasen 2005-02-09 18:49:09 UTC
Created attachment 37261 [details]
a screenshot
Comment 4 Vincent Noel 2005-02-09 21:21:46 UTC
Will the menu appear rotated as well ? :)
Comment 5 Matthias Clasen 2005-02-11 07:16:13 UTC
2005-02-11  Matthias Clasen  <mclasen@redhat.com>

	Support vertical menubars  (#166632): 
	
	* gtk/gtkenums.h (GtkPackDirection): New enumeration for pack 
	directions, with values for left-to-right, right-to-left, 
	top-to-bottom and bottom-to-top.

	* gtk/gtk.symbols: 
	* gtk/gtkmenubar.h: 
	* gtk/gtkmenubar.c: Add two properties, pack-direction and
	child-pack-direction, which specify how children and 
	grandchildren of a menubar are packed, with getters and setters. 

	* gtk/gtkmenubar.c (gtk_menu_bar_set_property): 
	(gtk_menu_bar_get_property): Implement set_property and get_property.

	* gtk/gtkmenubar.c (gtk_menu_bar_size_request): 
	(gtk_menu_bar_size_allocate): Take pack direction into account.

	* gtk/gtkmenubar.c (gtk_menu_bar_move_current): Implement 
	move_current here move all the menubar-specific direction 
	tweaking from the generic menushell implementation here.

	* gtk/gtkmenu.c (gtk_menu_move_current): Move  menu-specific 
	direction tweaking from the generic menushell implementation here.

	* gtk/gtkmenuitem.c (gtk_menu_item_size_request): 
	(gtk_menu_bar_size_allocate): Take pack direction into account.

	* gtk/gtkimagemenuitem.c (gtk_image_menu_item_size_request) 
	(gtk_image_menu_item_size_allocate): 
	(gtk_image_menu_item_toggle_size_request): Take child pack 
	direction into account and pack the image vertically if
	necessary.

	* gtk/gtkmenushell.c (gtk_menu_shell_real_select_item):
	Set the submenu direction to left-right for menuitems in 
	vertical menubars.
	(gtk_real_menu_shell_move_current): Simplify by moving
	direction tweaking to menu- and menubar-specific 
	implementations. Take pack direction into account when
	doing fallbacks.

	* tests/testmenubars.c: Test menubars in various packing
	direction combinations.

	* tests/Makefile.am (noinst_PROGRAMS): Add testmenubars.
Comment 6 Vincent Noel 2005-02-11 14:53:40 UTC
So is this bug fixed ?
Comment 7 Tamara Roberson 2005-02-18 21:32:34 UTC
I fail to see the point. Menus on other sides are unreadable. If you need
toolbars on the top and side then you probably should rework what needs to be on
the toolbar and what doesn't, not fill the screen with them.
Comment 8 Dafydd Harries 2005-05-14 09:22:10 UTC
Regardless of whether this is readable in English, note that there are languages
which are often written vertically.