GNOME Bugzilla – Bug 166480
add GTK_STOCK_FULLSCREEN and GTK_STOCK_INFO
Last modified: 2011-02-04 16:18:41 UTC
I propose that GTK_STOCK_FULLSCREEN and GTK_STOCK_INFO are added. Most viewers need these (totem, eog, etc). Since #define GTK_STOCK_ZOOM_100 #define GTK_STOCK_ZOOM_FIT #define GTK_STOCK_ZOOM_IN #define GTK_STOCK_ZOOM_OUT are also in there I don't see why fullcreen also shouldn't. GTK_STOCK_INFO couldn't be a nice icon that the user knows when it is clicked it will give some info. A Questionmark or something maybe?
I agree about the need for a fullscreen stock icon. But GTK_STOCK_INFO seems more or less the same as GTK_STOCK_PROPERTIES. Just my 0.02 €
If we add fullscreen, we probably should probably add exit_fullscreen as well. We need LGPL images for those, though. The ones in gnome-icon-theme are GPL.
Just for reference, Info stock item by jimmac: http://jimmac.musichall.cz/ikony/i52/stock-info-16.png Fullscreen stock items by jimmac: http://cvs.gnome.org/viewcvs/*checkout*/gnome-icon-theme/16x16/stock/generic/stock_fullscreen.png?rev=1.1 http://cvs.gnome.org/viewcvs/*checkout*/gnome-icon-theme/24x24/stock/generic/stock_fullscreen.png?rev=1.1 http://cvs.gnome.org/viewcvs/*checkout*/gnome-icon-theme/16x16/stock/generic/stock_leave-fullscreen.png?rev=1.1 http://cvs.gnome.org/viewcvs/*checkout*/gnome-icon-theme/24x24/stock/generic/stock_leave-fullscreen.png?rev=1.1 Jimmac? Are you OK with LGPLing and including them in GTK+?
Sure thing.
Nice :). One last question: http://jimmac.musichall.cz/ikony/i52/stock-info-16.png doesn't seem to match http://cvs.gnome.org/viewcvs/*checkout*/gimp/themes/Default/images/stock-info-16.png?rev=1.1 Kristof, jimmac: The latter seems to match GTK_STOCK_DIALOG_INFO. Having GTK_STOCK_INFO and GTK_STOCK_DIALOG_INFO doesn't seem useful to me. Which one should be used? Should we simply use the latter as GTK_STOCK_INFO and #define GTK_STOCK_DIALOG_INFO GTK_STOCK_INFO, or are they really referring to totally different things?
GTK_STOCK_DIALOG_INFO is more for dialogs (dialog is mostly some feedback to the user that there is a problem or something, that's why it is a lightball) and GTK_STOCK_INFO is info about a thing like a song a file or something like that (info about an object) so using different icons is appropriated I think what are your thoughts jimmac?
If they are different in meaning, it would be nice to have a 24x24 sized version. Jimmac? :)
as for the 16x16 version of dialog info, this light bulb was crafted for 16x16:
Created attachment 37249 [details] 16x16px lightbulb icon
jimmac: Maybe you could provide a 24x24 version of the i with a blue circle (http://jimmac.musichall.cz/ikony/i52/stock-info-16.png)?
maybe having: #define GTK_STOCK_DIALOG_INFO GTK_STOCK_INFO is good enough plz add it together with the fullscreen STOCK ITEMS.
If I remember correctly, GTK_STOCK_DIALOG_INFO was meant to be another icon than GTK_STOCK_INFO.
I'd also like to have a GTK_STOCK_INFO liek a 'i' with a blue circle underneath. I am using such one to show document meta data (author, title, description, ...).
Stephen the use case you describe is exactly what GTK_STOCK_PROPERTIES is intended for, if you dont like the look of that icon you should be trying to theme it.
Everything here seems to have been discussed and settled. Why aren't the new icons in CVS yet? Do you need help with that or are you waiting for approval from the GTK+ developers?
2005-06-25 Matthias Clasen <mclasen@redhat.com> Add some new stock items. (#166480, Kristof Vansant) * gtk/stock-icons/stock_fullscreen_16.png: * gtk/stock-icons/stock_fullscreen_24.png: * gtk/stock-icons/stock_leave_fullscreen_16.png: * gtk/stock-icons/stock_leave_fullscreen_24.png: * gtk/stock-icons/stock_info_16.png: * gtk/stock-icons/stock_info_24.png: New icons. * gtk/stock-icons/Makefile.am: Add new icons. * gtk/gtkstock.h: Define names for the new icons. * gtk/gtkstock.c (builtin_items): Register new stock items. * gtk/gtkiconfactory.c (get_default_icons): Register new stock icons.