After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 166145 - Fix for random crashes when unloading the smooth engine
Fix for random crashes when unloading the smooth engine
Status: RESOLVED FIXED
Product: gtk-engines
Classification: Deprecated
Component: general
unspecified
Other All
: High critical
: ---
Assigned To: gtk-engines maintainers
gtk-engines maintainers
: 165942 166018 166418 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2005-02-03 10:48 UTC by Kjartan Maraas
Modified: 2005-02-07 02:59 UTC
See Also:
GNOME target: ---
GNOME version: 2.9/2.10

Attachments
patch to fix crash (1.95 KB, patch)
2005-02-03 10:49 UTC, Kjartan Maraas 		none Details | Review

Description Kjartan Maraas 2005-02-03 10:48:08 UTC 
The use of g_quark_from_static_string() in modules that are loaded and unloaded
dynamically is causing crashes in random applications. This patch changes the
theme engine to use g_quark_from_string() which makes a copy of the string so it
doesn't have to be there for the entire lifecycle of the app.

I've been unable to cause any crashes when changing themes after applying this.
I would recommend that this be backported to the stable branch too since we've
had this bug for ages it seems.
Comment 1 Kjartan Maraas 2005-02-03 10:49:46 UTC 
Created attachment 36909 [details] [review]
patch to fix crash
Comment 2 Kjartan Maraas 2005-02-03 10:51:38 UTC 
*** Bug 165942 has been marked as a duplicate of this bug. ***
Comment 3 Kjartan Maraas 2005-02-03 10:52:15 UTC 
*** Bug 166018 has been marked as a duplicate of this bug. ***
Comment 4 Andrew Johnson 2005-02-03 12:33:48 UTC 
whoops. Looks like I should have commented and commited yesterday. I figured out
the problem almost immediately after 166018 was posted but got busy at work and
forgot.

This crasher had been hapening for quite some time on the Smooth 0.6 branch but
I couldn't find it, and then it simply stopped happening so I (wrongly) presumed
something else I had done fixed it.

I will get this patch into cvs immediately, thanks Kjartan and Matthias.
Comment 5 Andrew Johnson 2005-02-03 12:59:29 UTC 
Done. I Will be releasing a 0.6.0.1 bugfix release of Smooth today, and am going
to push for a 2.6.1 gtk engines release asap.
Comment 6 Kjartan Maraas 2005-02-03 14:58:30 UTC 
Thanks a bunch for the quick response. I think this will have quite a positive
impact on the stability of the new releases on the whole.
Comment 7 Elijah Newren 2005-02-07 02:59:57 UTC 
*** Bug 166418 has been marked as a duplicate of this bug. ***