After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 166065 - Theme Selection Table in Theme Preferences isn't reported by speech
Theme Selection Table in Theme Preferences isn't reported by speech
Status: RESOLVED FIXED
Product: gnopernicus
Classification: Deprecated
Component: speech
unspecified
Other Linux
: Normal normal
: ---
Assigned To: remus draica
remus draica
AP1
Depends on: 167347
Blocks:
 
 
Reported: 2005-02-02 17:51 UTC by John Crawley
Modified: 2005-05-13 10:28 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
propsed patch (635 bytes, patch)
2005-02-07 12:05 UTC, Dana Ormenisan
none Details | Review
proposed patch (1005 bytes, patch)
2005-02-08 13:21 UTC, remus draica
committed Details | Review
patch to fix the problem (666 bytes, patch)
2005-05-10 08:37 UTC, remus draica
accepted-commit_now Details | Review

Description John Crawley 2005-02-02 17:51:34 UTC
Using nightly build with gnopernicus 0.10.0.

 - Start up gnopernicus with speech enabled.
 - From the main menu, go to Preferences->Desktop Preferences->Display->Theme

Notice that the 'Theme Preferences' window appears. Speech will report the
window name and current table line. However, the table name is not reported.
This is not so serious as the table line is reported and the user can figure
out that they are focussed on a table.

The real problem is when the user navigates to the table from the "Close" 
or "Install Theme" buttons. In these cases, neither the table line or the
table name is reported - the user gets no feedback until he/she presses the
<up> or <down> key.
Comment 1 bill.haneman 2005-02-03 16:06:35 UTC
it sounds as though the 'context change' heuristics may be failing in
gnopernicus  for this case.
Comment 2 Dana Ormenisan 2005-02-07 12:05:53 UTC
Created attachment 37096 [details] [review]
propsed patch

This patch will fix the problem when the user navigates back to the table from
the "Close" or "Install Theme" buttons.

The remained issue is that only the "context" information is reported after
applying the patch. The current table line should be also reported.
Comment 3 remus draica 2005-02-08 13:21:13 UTC
Created attachment 37161 [details] [review]
proposed patch
Comment 4 Alexandra Telescu 2005-02-14 12:58:42 UTC
Testing the patch, I observed:
 1. The current selected line is reported most of the time.
 2. When the line is not reported,  bug 157958 is the cause.
 3. Switching to the second line, the second line is not reported. Cause:
Object-descendent-change event' is not present, so gnopernicus does not report
the change of the table line. If I move back to the first line (the line is
reported) and then again down to the second line, the event is present and the
line is reported.
Comment 5 Alexandra Telescu 2005-02-14 13:36:43 UTC
Bug  167347 was filed for the missing of 'active-descendant-event'.
Comment 6 bill.haneman 2005-02-14 14:37:39 UTC
It is wrong to expect 'active-descendant-changed' in cases where the active
descendant has not changed, but is being presented for the first time.

So gnopernicus must find another solution for this issue.
Comment 7 bill.haneman 2005-02-14 15:15:23 UTC
Please ignore my comment #6, Remus has corrected me.  In the case of this bug,
the active descendant is in fact changing.
Comment 8 John Crawley 2005-02-18 14:29:10 UTC
Changing the AP value to match corresponding iternal bug.
Comment 9 remus draica 2005-03-21 13:41:06 UTC
Comment on attachment 37161 [details] [review]
proposed patch


Patch committed on cvs head.
Comment 10 remus draica 2005-05-10 08:36:38 UTC
The patch applied contains a small error. A part of the code is not in the right
block.
Comment 11 remus draica 2005-05-10 08:37:39 UTC
Created attachment 46272 [details] [review]
patch to fix the problem
Comment 12 remus draica 2005-05-13 10:27:43 UTC
Comment on attachment 46272 [details] [review]
patch to fix the problem


Patch committed on head.