After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 165917 - Don't save window size on exit if maximized
Don't save window size on exit if maximized
Status: RESOLVED FIXED
Product: blam
Classification: Other
Component: General
1.6.x
Other Linux
: Normal minor
: ---
Assigned To: Mikael Hallendal
Mikael Hallendal
Depends on:
Blocks:
 
 
Reported: 2005-02-01 11:13 UTC by Julien Olivier
Modified: 2005-02-04 22:55 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Proposed Patch (3.10 KB, patch)
2005-02-03 08:30 UTC, Peter Rother
none Details | Review
Fixed version of the patch (3.57 KB, patch)
2005-02-04 22:54 UTC, Mikael Hallendal
none Details | Review

Description Julien Olivier 2005-02-01 11:13:04 UTC
Using metacity as the window manager

- Open blam
- maximize its window
- close it
- re-open blam
- it takes all the screen, and it's impossible to un-maximize it by clicking on
the "square" next to the close icon in metacity's title bar.

This is because you shouldn't save the window's size if the window is maximized
when you quit blam. Just keep the last un-maximied size as the default window size.
Comment 1 Mikael Hallendal 2005-02-02 08:53:14 UTC
I was sure that this was already handled this way but apparently not. Should
however save that it's maximized state and re-maximize it when restarted but
then let you click the unmaximize to get back to the default size.
Comment 2 Peter Rother 2005-02-03 08:30:37 UTC
Created attachment 36906 [details] [review]
Proposed Patch

Hi, here's a patch I whipped up real quick ... should solve the problem. There
are various other states that can be used in this situation such as "Sticky" or
"Withdrawn" (look at doc for Gdk.WindowState enum) but I'll leave those up to
someone else.
Comment 3 Mikael Hallendal 2005-02-04 22:54:51 UTC
Created attachment 37009 [details] [review]
Fixed version of the patch

Commited this fixed version of the patch. Changes:

* Missed main_window_state in schema file
* Should restore window size and position even if it's maximized. (since
unmaximizing will go back to these values).
Comment 4 Mikael Hallendal 2005-02-04 22:55:25 UTC
Thanks a lot for the patch, if you are interested you can see what changes I
made to it before commited in the patch above.