After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 165452 - random values returned from functions
random values returned from functions
Status: RESOLVED FIXED
Product: gok
Classification: Deprecated
Component: build
unspecified
Other Linux
: Normal minor
: ---
Assigned To: David Bolter
David Bolter
Depends on:
Blocks: 165420
 
 
Reported: 2005-01-27 21:32 UTC by Chris Lahey
Modified: 2005-02-03 14:57 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed fix. (2.79 KB, patch)
2005-01-27 21:33 UTC, Chris Lahey 		needs-work Details | Review
my version of the patch, against HEAD (2.19 KB, patch)
2005-01-28 21:36 UTC, bill.haneman 		accepted-commit_now Details | Review

Description Chris Lahey 2005-01-27 21:32:25 UTC 
control reaches end of non-void functions
Comment 1 Chris Lahey 2005-01-27 21:33:09 UTC 
Created attachment 36617 [details] [review]
Proposed fix.
Comment 2 David Bolter 2005-01-27 21:37:40 UTC 
Looks like a worthy patch.  How did you catch these? (what compiler flag)
Comment 3 bill.haneman 2005-01-28 21:16:29 UTC 
Comment on attachment 36617 [details] [review]
Proposed fix.

the return values for the virtual functions (i.e. the ones that use func
pointers) are not right.

We should be returning, for instance,

	if (klass->predict)
		return (* klass->predict) (complete, num_predictions);
Comment 4 bill.haneman 2005-01-28 21:36:50 UTC 
Created attachment 36671 [details] [review]
my version of the patch, against HEAD
Comment 5 David Bolter 2005-01-28 21:41:28 UTC 
Comment on attachment 36671 [details] [review]
my version of the patch, against HEAD

Looks good.  Thanks both.